Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): ethereumjs-util@6->^7.1.5 #11932

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix(deps): ethereumjs-util@6->^7.1.5 #11932

wants to merge 10 commits into from
+309 −278

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 21, 2024 •
edited
Loading

Description

Bump deprecated dependencies to (still deprecated but) lated versions with various fixes and improvements:

  • fix: unpin and update ethereumjs-util from 6.1.0 to ^7.1.5

Related issues

Based on

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat mentioned this pull request Oct 21, 2024
Closed
@socket-security Socket Security
Copy link

socket-security bot commented Oct 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/bn.js@4.11.6 None 0 13.9 kB types
npm/@types/bn.js@5.1.6 None 0 13.9 kB types
npm/ethereumjs-abi@0.6.8 None +2 1.05 MB holgerd77

🚮 Removed packages: npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/ethereumjs-abi@0.6.6, npm/file-uri-to-path@1.0.0

View full report↗︎

This was referenced Oct 21, 2024
Closed
Merged
@legobeat legobeat added team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@legobeat legobeat changed the title deps: ethereumjs-util@6.1.0->^7.1.5 fix(deps): ethereumjs-util@6.1.0->^7.1.5 Oct 21, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
legobeat
legobeat commented Oct 21, 2024
View reviewed changes
app/store/migrations/029.ts Outdated
@@ -466,7 +465,7 @@ export default async function migrate(stateAsync: unknown) {
if (Array.isArray(transactionControllerState.transactions)) {
transactionControllerState.transactions.forEach(
(transaction: TransactionParams, index: number) => {
if (transaction && !isHexString(transaction.chainId)) {
if (transaction && !transaction.chainId || (transaction.chainId && !isHexString(transaction.chainId))) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not change the resulting logic and is just validating transaction.chainId to account for that isHexString does not accept arbitrary input.

I am not sure if it is correct and intended that this should evaluate to true when transaction.chainId is undefined (or otherwise not sane to pass to toHex), or if explicit handling for that should actually be added.

@legobeat legobeat changed the base branch from main to ellul/resolve-secp256k1 October 21, 2024 23:56
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch from 5afd1f3 to c1fe27f Compare October 22, 2024 00:04
@legobeat legobeat mentioned this pull request Oct 22, 2024
Merged
4 tasks
Base automatically changed from ellul/resolve-secp256k1 to main October 22, 2024 11:07
@legobeat legobeat mentioned this pull request Oct 23, 2024
Draft
12 tasks
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch 2 times, most recently from 281315e to 0688d0b Compare October 23, 2024 08:50
This was referenced Oct 23, 2024
Merged
Open
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
@legobeat
fix: migrate from legacy ethjs to @metamask/ethjs (#11969)
8229dbc 
## **Description**

- fix: migrate from legacy `ethjs-` packages to maintained and already
used `@metamask/ethjs-` forks
  - Removes dependency on deprecated `babel-runtime` v6
  - Bundle size reduction

## **Related issues**

- #11952
- #11932

#### Blocking
- #11968

## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch 2 times, most recently from 754bf84 to df69679 Compare October 23, 2024 13:54
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: df69679
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d7c6ba5-318b-4646-a2c6-8c67e1c64f60

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This was referenced Oct 23, 2024
Merged
Draft
@legobeat legobeat changed the title fix(deps): ethereumjs-util@6.1.0->^7.1.5 fix(deps): ethereumjs-util@6->^7.1.5 Oct 23, 2024
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch from df69679 to 5ff36d8 Compare October 23, 2024 14:36
@legobeat legobeat mentioned this pull request Oct 28, 2024
Open
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f84b8d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb365dce-ee3b-4ad2-af03-195569eed833

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch 5 times, most recently from 0299a2e to 7818d3f Compare October 29, 2024 13:04
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch from 7818d3f to 7e3ed75 Compare October 29, 2024 19:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicholasEllul NicholasEllul added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@NicolasMassart NicolasMassart self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Mar 3, 2025
@NicolasMassart
Copy link
Contributor

this requires #11972 to be merged first

@NicolasMassart NicolasMassart marked this pull request as draft March 7, 2025 13:07
@NicolasMassart NicolasMassart added the team-mobile-platform Mobile Platform team label Mar 7, 2025
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NicolasMassart NicolasMassart

Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-lavamoat team-mobile-platform Mobile Platform team team-security
Projects
PR review queue
Status: Needs more work from the author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @codecov-commenter @NicolasMassart @NicholasEllul