fix(deps): ethereumjs-util@6->^7.1.5 #11932
Open
+309
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/ethereumjs-abi@0.6.6, npm/file-uri-to-path@1.0.0 |
This was referenced Oct 21, 2024
legobeat
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
legobeat
commented
Oct 21, 2024
app/store/migrations/029.ts
Outdated
| @@ -466,7 +465,7 @@ export default async function migrate(stateAsync: unknown) { | |||
| if (Array.isArray(transactionControllerState.transactions)) { | |||
| transactionControllerState.transactions.forEach( | |||
| (transaction: TransactionParams, index: number) => { | |||
| if (transaction && !isHexString(transaction.chainId)) { | |||
| if (transaction && !transaction.chainId || (transaction.chainId && !isHexString(transaction.chainId))) { | |||
There was a problem hiding this comment.
This does not change the resulting logic and is just validating transaction.chainId to account for that isHexString does not accept arbitrary input.
I am not sure if it is correct and intended that this should evaluate to true when transaction.chainId is undefined (or otherwise not sane to pass to toHex), or if explicit handling for that should actually be added.
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
from
5afd1f3 to
c1fe27f
Compare
4 tasks
12 tasks
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
2 times, most recently
from
281315e to
0688d0b
Compare
This was referenced Oct 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
## **Description** - fix: migrate from legacy `ethjs-` packages to maintained and already used `@metamask/ethjs-` forks - Removes dependency on deprecated `babel-runtime` v6 - Bundle size reduction ## **Related issues** - #11952 - #11932 #### Blocking - #11968 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
2 times, most recently
from
754bf84 to
df69679
Compare
legobeat
added
Run Smoke E2E
|
This was referenced Oct 23, 2024
legobeat
changed the title
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
from
df69679 to
5ff36d8
Compare
|
legobeat
added
Run Smoke E2E
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
from
eb0c3e4 to
10bcec0
Compare
9 tasks
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
from
10bcec0 to
8f84b8d
Compare
legobeat
added
Run Smoke E2E
|
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
5 times, most recently
from
0299a2e to
7818d3f
Compare
- to get correct types - to prepare upgrading to versions which don't provide the re-export - fix: vendor BNToHex and hexToBN in order to use bn.js v4 - fix: explicitly use either bn.js@4 and bn.js@5 - Why mixing v4 and v5 is A Bad Thing: ethereumjs/ethereumjs-util#250
legobeat
force-pushed
the
deps-ethereumjs-util-7
branch
from
7818d3f to
7e3ed75
Compare
|
NicholasEllul
added
Run Smoke E2E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump deprecated dependencies to (still deprecated but) lated versions with various fixes and improvements:
ethereumjs-utilfrom6.1.0to^7.1.5Related issues
.toString(16)indutny/bn.js#295Based on
Blocking
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist