Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json-rpc-middleware-stream@3.0.0->^4.2.3 #11978

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: json-rpc-middleware-stream@3.0.0->^4.2.3 #11978

merged 1 commit into from
Oct 25, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited
Loading

Description

  • Bump json-rpc-middleware-stream from 3.0.0 (2020-12-08) to ^4.2.3 (2023-09-27)
    • Hold at v4 to prevent breaking upgrade from readable-stream v2 to v3

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/json-rpc-middleware-stream@4.2.3 None 0 22.3 kB gudahtt

🚮 Removed packages: npm/json-rpc-middleware-stream@3.0.0

View full report↗︎

@legobeat legobeat changed the title deps: json-rpc-middleware-stream@3.0.0->^4.2.3 fix: json-rpc-middleware-stream@3.0.0->^4.2.3 Oct 23, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e154d05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/71966348-6982-42c1-ad58-5af0f4ca839e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat marked this pull request as ready for review October 23, 2024 14:46
@legobeat legobeat requested review from a team as code owners October 23, 2024 14:46
@legobeat legobeat mentioned this pull request Oct 23, 2024
Merged
23 tasks
@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from e154d05 to 899cb4e Compare October 23, 2024 14:53
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from 6a284b4 to 8db383b Compare October 23, 2024 15:23
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8db383b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/184a7595-bdf9-4db2-9f80-78d430d7735d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from 8db383b to 917cd9d Compare October 23, 2024 15:43
@legobeat legobeat requested a review from a team October 23, 2024 15:59
@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from 917cd9d to 7c233ac Compare October 23, 2024 17:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (9f72156) to head (7c233ac).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11978   +/-   ##
=======================================
  Coverage   55.12%   55.12%           
=======================================
  Files        1752     1752           
  Lines       39563    39563           
  Branches     4922     4922           
=======================================
  Hits        21811    21811           
  Misses      16249    16249           
  Partials     1503     1503

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from 7c233ac to 1275626 Compare October 24, 2024 00:40
@legobeat legobeat mentioned this pull request Oct 24, 2024
Merged
8 tasks
@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch 2 times, most recently from 6970599 to 89991b8 Compare October 25, 2024 01:29
@legobeat legobeat removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 25, 2024
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 89991b8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf10c2af-5202-4f1b-9a02-31dfe2913ecc

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
deps: json-rpc-middleware-stream@3.0.0->^4.2.3
d1114bb 
last still on readable-stream@2
@legobeat legobeat force-pushed the deps-eth-json-middleware-stream branch from 89991b8 to d1114bb Compare October 25, 2024 01:42
Cal-L
Cal-L approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@legobeat legobeat enabled auto-merge October 25, 2024 01:46
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d1114bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9dab47e4-bdfd-4fd1-a092-cf1dfc352a44

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit e0cbf75 Oct 25, 2024
42 of 43 checks passed
@legobeat legobeat deleted the deps-eth-json-middleware-stream branch October 25, 2024 02:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-lavamoat team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @codecov-commenter @Cal-L @metamaskbot