-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: ethereumjs-util 7 #11930
deps: ethereumjs-util 7 #11930
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/file-uri-to-path@1.0.0 |
- use version from npm, not github
70084c8
to
5afd1f3
Compare
@@ -466,7 +465,7 @@ export default async function migrate(stateAsync: unknown) { | |||
if (Array.isArray(transactionControllerState.transactions)) { | |||
transactionControllerState.transactions.forEach( | |||
(transaction: TransactionParams, index: number) => { | |||
if (transaction && !isHexString(transaction.chainId)) { | |||
if (transaction && !transaction.chainId || (transaction.chainId && !isHexString(transaction.chainId))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not change the resulting logic and is just validating transaction.chainId
to account for that isHexString
does not accept arbitrary input.
I am not sure if it is correct and intended that this should evaluate to true
when transaction.chainId
is undefined
(or otherwise not sane to pass to toHex
), or if explicit handling for that should actually be added.
Superseded by #11932 |
Description
Bump deprecated dependencies to (still deprecated but) lated versions with various fixes and improvements:
ethereumjs-util
from6.1.0
to^7.1.5
ethereumjs-abi
from0.6.6
to^0.6.8
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist