wip: simplify fromTokenMinimalUnit

MetaMask · Oct 28, 2024 · 9598284 · 9598284
1 parent 0cda5f4
commit 9598284
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/app/util/number/index.js b/app/util/number/index.js
@@ -116,8 +116,14 @@ export function fromWei(value = 0, unit = 'ether') {
 export function fromTokenMinimalUnit(
   minimalInput,
   decimals = 0,
-  isRounding = true,
+  _isRounding = true,
 ) {
+  const value = new BigNumber(
+    (isBN(minimalInput) ? minimalInput.toString(10) : minimalInput),
+    10,
+  )
+  return value.div(new BigNumber(decimals, 10)).toString(10, decimals);
+  /*
   minimalInput = isRounding ? Number(minimalInput) : minimalInput;
   const prefixedInput = addHexPrefix(minimalInput.toString(16));
   let minimal = safeNumberToBN(prefixedInput);
@@ -138,6 +144,7 @@ export function fromTokenMinimalUnit(
     value = '-' + value;
   }
   return value;
+  */
 }
 
 /**
@@ -385,6 +392,9 @@ export function toBN(value) {
   if (typeof value === 'number' && isNaN(value) || !value || value === 'NaN') {
     return new BN(0);
   }
+  if (isBN(value)) {
+    return value;
+  }
   return value?.startsWith('0x')
     ? hexToBN(value)
     : new BN(value || '0');