Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2795): remove duplicate description in account connect multiselect screen #10851

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Aug 28, 2024

Description

There was a duplicate description below the tilt in the multiselect account screen, introduced 5 days ago in PR #10715 through a bad merge commit. This is now fixed.

Related issues

Fixes:

Manual testing steps

  1. Go to the in-app browser and open a dapp like uniswap and connect to it
  2. Click on add more accounts, the description below the title was showing in double, this is now fixed

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Aug 28, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the title fix(2795): remove duplicate title in account connect multiselect screen fix(2795): remove duplicate description in account connect multiselect screen Aug 28, 2024
Copy link

@EtherWizard33 EtherWizard33 marked this pull request as ready for review August 28, 2024 12:27
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner August 28, 2024 12:27
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9b4e6d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b95162a-7b1d-4d87-b20a-40fb494bc7e8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 merged commit f965eb8 into main Aug 28, 2024
57 checks passed
@EtherWizard33 EtherWizard33 deleted the fix-2795-remove-duplicate-title-in-account-connect-mulitiselect branch August 28, 2024 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants