Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2795 disconnect all account permission multichain edit account screen #10715

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Aug 20, 2024

Description

Behind feature flag for now, adds the ability to disconnect all accounts from the edit account screen.

Related issues

Contributes to resolving: https://github.com/MetaMask/MetaMask-planning/issues/2795

Manual testing steps

  1. Connect one or more account(s) to a dapp in the in app browser
  2. Select the dapp, in the header click the account avatar, a bottom sheet comes up, click Disconnect, a confirmation modal will show up.
  3. Click Disconnect, then a toast should show up.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Aug 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b32eeb2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8b6ba86-d8c9-4c21-9f82-2eb0694aaf62

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 marked this pull request as ready for review August 21, 2024 12:50
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner August 21, 2024 12:50
@jonybur jonybur requested a review from tommasini August 21, 2024 15:19
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We are solving the audit ci issue as we speak, let's merge it after

@EtherWizard33 EtherWizard33 added team-wallet-ux Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-wallet-ux Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74fa468
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6811fb7b-f106-4490-b2c0-9a012d376871

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@EtherWizard33 EtherWizard33 merged commit 2ee941a into main Aug 23, 2024
33 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2795-disconnect-all-account-permission-multichain-edit-account-screen branch August 23, 2024 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants