-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 2795 disconnect all account permission multichain edit account screen #10715
feat: 2795 disconnect all account permission multichain edit account screen #10715
Conversation
… since new code is behind feature flag
… since new code is behind feature flag
… since new code is behind feature flag
…een as well as confirmation modal
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… to show the hostname and favicon of the dapp that was disconnected
Bitrise✅✅✅ Commit hash: b32eeb2 Note
|
...AccountPermissions/AccountPermissionsConfirmRevokeAll/AccountPermissionsConfirmRevokeAll.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We are solving the audit ci issue as we speak, let's merge it after
Bitrise✅✅✅ Commit hash: 74fa468 Note
|
Quality Gate passedIssues Measures |
Description
Behind feature flag for now, adds the ability to disconnect all accounts from the edit account screen.
Related issues
Contributes to resolving: https://github.com/MetaMask/MetaMask-planning/issues/2795
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist