Skip to content

Commit

Permalink
fix(2795): remove duplicate description in account connect multiselec…
Browse files Browse the repository at this point in the history
…t screen (#10851)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
There was a duplicate description below the tilt in the multiselect
account screen, introduced 5 days ago in PR #10715 through a bad merge
commit. This is now fixed.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to the in-app browser and open a dapp like uniswap and connect to
it
2. Click on add more accounts, the description below the title was
showing in double, this is now fixed

## **Screenshots/Recordings**
| Before       | After        |
|--------------|--------------|
| <img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM"
src="https://github.com/user-attachments/assets/29093205-03a8-46f1-8d5b-c56626956008">
|<img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM"
src="https://github.com/user-attachments/assets/6f496cc5-8d1d-4975-8485-af35dee159a3">
|


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
EtherWizard33 authored Aug 28, 2024
1 parent 67eafcf commit f965eb8
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,6 @@ const AccountConnectMultiSelector = ({
{isMutichainVersion1Enabled
? strings('accounts.select_accounts_description')
: strings('accounts.connect_description')}
{isMutichainVersion1Enabled
? strings('accounts.select_accounts_description')
: strings('accounts.connect_description')}
</Text>
{isMutichainVersion1Enabled && renderSelectAllCheckbox()}
{areAllAccountsSelected
Expand Down

0 comments on commit f965eb8

Please sign in to comment.