Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resending a transaction does not work anymore #3374

Closed
Swift42 opened this issue Mar 1, 2018 · 12 comments
Closed

Resending a transaction does not work anymore #3374

Swift42 opened this issue Mar 1, 2018 · 12 comments
Assignees

Comments

@Swift42
Copy link

Swift42 commented Mar 1, 2018

It seems that the update from yesterday broke my MetaMask:

I tried to send some transactions with a low gas. Normally MetaMask displays a text/link like "Taking too long? Resend the transaction here" after a few seconds. But this link isn't displayed anymore.
To be sure I waited some hours and restarted Chrome/Metamask several times, but the link does not show up.

This means: Currently my transactions are stuck because I cannot raise the gas with MetaMask.

@Swift42
Copy link
Author

Swift42 commented Mar 1, 2018

Oops, davesumter was 3 minutes faster :-)
So this is a duplicate of #3373 ...

@davewc
Copy link

davewc commented Mar 1, 2018

Swift42, I had to replace a TX using MEW as a workaround, but it's messy..

This is probably one of the most important features for me. I send hundreds of TX's a day and many get stuck. I pretty much can't use MM in chrome now..

@Swift42
Copy link
Author

Swift42 commented Mar 1, 2018

Yes, I thought about MEW, too, but as you said: it's messy.
So I likely wait for a MetaMask fix, which comes hopefully today or tomorrow.
I think this is severe bug (T0-bug / P1-asap).

@davewc
Copy link

davewc commented Mar 1, 2018

yeah, I run a dapp with a few hundred users and everyone has stuck tx's..

very very severe..

@fabiohild
Copy link

Same issue here, I'm willing to help if anyone provides the guidance on what has to be done, I have a client stuck at the moment and they would not be able to use the MEW method.

@davewc
Copy link

davewc commented Mar 1, 2018

I'm kind of annoyed these extension's seem to have auto updated to a buggy version. I would prefer to stay on one version when it's working..

@fabiohild
Copy link

fabiohild commented Mar 1, 2018

Chrome automatically updates all extensions, and curiously does not allow to force updates (we'll probably go through this once the issue is solved, we'll have to wait until chrome decides to update). I'm not sure about the other Browsers though, might be possible.

edit: Firefox allow disabling updates from extensions.

@davewc
Copy link

davewc commented Mar 1, 2018

I'm using firefox now
slow as hell, but at least I can resend

@Swift42
Copy link
Author

Swift42 commented Mar 2, 2018

I forced my chrome to update to MetaMask 4.1.3 (Addons -> Dev Mode -> Update all addons) and it is now working again. I was able to resend all stuck transactions with a higher fee.
Thank you for the fix.

@danjm
Copy link
Contributor

danjm commented Mar 3, 2018

Thanks @Swift42 for reporting this. Much appreciated.

@mryellow
Copy link

This has regressed in some way? Not seeing retry buttons.

@mryellow
Copy link

A new transaction created with MEW for the purposes of beating this nonce and cancelling the transaction, thanks to new code instead gets a new valid nonce. This leaves the old transaction.

Interestingly the new transaction created by MEW has the retry button.

Could this be existing transactions are not having the correct "status"?
I'm not sure where this is being handled in the current layout and if "old-ui" is still used where status is checked for submitted...

If I'm seeing this right lot of people will be left with stuck transactions if the current build isn't rolled back or a hotfix created which puts their older transactions in a state where the retry button is shown.

github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
## **Description**

Remove global network usage from all signature components and hooks.

Specifically:

- Replace usages of the following selectors with the chain ID extracted
from the signature request.
  - `getCurrentChainId`
  - `getNativeCurrency`
  - `getProviderConfig`
- Add new selectors:
  - `selectNetworkConfigurationByChainId`
  - `selectDefaultRpcEndpointByChainId`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28167?quickstart=1)

## **Related issues**

Fixes:
[#3375](MetaMask/MetaMask-planning#3375)
[#3500](MetaMask/MetaMask-planning#3500)
[#3459](MetaMask/MetaMask-planning#3459)
[#3374](MetaMask/MetaMask-planning#3374)

## **Manual testing steps**

Regression of all signature types including legacy and redesigned
confirmations.

Also verify Blockaid warnings.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants