Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry with higher gas no longer showing #3373

Closed
davewc opened this issue Mar 1, 2018 · 2 comments
Closed

Retry with higher gas no longer showing #3373

davewc opened this issue Mar 1, 2018 · 2 comments

Comments

@davewc
Copy link

davewc commented Mar 1, 2018

The retry with higher gas option is no longer showing for pending tx's.

Stopped about 15 hours ago. No change to the extension..
@Swift42 Swift42 mentioned this issue Mar 1, 2018
Closed
@danjm
Copy link
Contributor

danjm commented Mar 3, 2018

Thanks @davesumter for reporting this. This was fixed in version 4.1.3, which was deployed earlier today and is now available on chrome.

@danjm danjm closed this as completed Mar 3, 2018
@davewc
Copy link
Author

davewc commented Mar 3, 2018

Thanks for the quick fix!

github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@matthewwalsh0 @jpuri
refactor: remove global network usage from transaction confirmations (#…
c564383 
…28236)

## **Description**

Remove usages of global network selectors from transaction confirmation
React components and hooks.

Specifically:

- Remove usages of the following selectors:
  - `getConversionRate`
  - `getCurrentChainId`
  - `getNativeCurrency`
  - `getNetworkIdentifier`
  - `getNftContracts`
  - `getNfts`
  - `getProviderConfig`
  - `getRpcPrefsForCurrentProvider`
- Add new selectors:
  - `selectConversionRateByChainId`
  - `selectNftsByChainId`
  - `selectNftContractsByChainId`
  - `selectNetworkIdentifierByChainId`
- Add ESLint rule to prevent further usage of global network selectors
in confirmations directory.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28236?quickstart=1)

## **Related issues**

Fixes:
[#3469](MetaMask/MetaMask-planning#3469)
[#3373](MetaMask/MetaMask-planning#3373)
[#3486](MetaMask/MetaMask-planning#3486)
[#3487](MetaMask/MetaMask-planning#3487)

## **Manual testing steps**

Full regression of all transaction confirmations and related
functionality.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davewc @danjm