Make provider errors more useful #3487
Comments
Closed
danfinlay
modified the milestones:
Sprint 03: April 10 Sprint,
Sprint 04,
Maintenance Sprint
|
Related to #3622 |
ghost
added
the
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 8, 2024
…28236) ## **Description** Remove usages of global network selectors from transaction confirmation React components and hooks. Specifically: - Remove usages of the following selectors: - `getConversionRate` - `getCurrentChainId` - `getNativeCurrency` - `getNetworkIdentifier` - `getNftContracts` - `getNfts` - `getProviderConfig` - `getRpcPrefsForCurrentProvider` - Add new selectors: - `selectConversionRateByChainId` - `selectNftsByChainId` - `selectNftContractsByChainId` - `selectNetworkIdentifierByChainId` - Add ESLint rule to prevent further usage of global network selectors in confirmations directory. [](https://codespaces.new/MetaMask/metamask-extension/pull/28236?quickstart=1) ## **Related issues** Fixes: [#3469](MetaMask/MetaMask-planning#3469) [#3373](MetaMask/MetaMask-planning#3373) [#3486](MetaMask/MetaMask-planning#3486) [#3487](MetaMask/MetaMask-planning#3487) ## **Manual testing steps** Full regression of all transaction confirmations and related functionality. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/28236?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #3140
When we switched to the new infura provider, we seem to have regressed in error comprehensibility. We are throwing generic
-32603for a ton of cases.Here's one simple web3 call that throws this error:
The response doesn't give us much to go on:
I'll lay that out as our first test-case. We should return at least a "method not found" error when a non existent method is thrown. Hopefully while that error message is added, we can pass some more meaningful data back in general, too.
The text was updated successfully, but these errors were encountered: