Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry transaction back into old ui transaction list item #3381

Merged
merged 3 commits into from
Mar 2, 2018
Merged

Add retry transaction back into old ui transaction list item #3381

merged 3 commits into from
Mar 2, 2018
+93 −35

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Mar 1, 2018 •
edited
Loading

Seems this is a regression from the transaction list item. Fixes #3374. This is only for the classic UI, will need to design for the new UI.

@tmashuang tmashuang requested a review from danjm March 1, 2018 22:51
danjm
danjm approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and QA'd. Was able to send a transaction with gas at 0.1 GWEI, then retry with gas at 25 GWEI. Code is now consistent with changes before regression. Merging.

@danjm danjm merged commit cb109a8 into master Mar 2, 2018
@whymarrh whymarrh deleted the OldUIretryTransaction branch November 19, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @danjm @dapperkangaroo