Added Further Portrait <50.01 Compatibility Handlers #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated AbstractIcon to handle new replacements for AeroTech to AeroTek and MechTech to MekTek for both category and filename. Renamed a couple of folders to bring them into compliance with usages across the rest of the codebase. It looks like a couple got renamed that shouldn't have. Added a portrait role group for Vehicle Crew, so Vehicle Crew will now gain random portraits. Previously they were excluded, despite the portraits being available.
IllianiCBT
added
Bug
Personnel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4935 +/- ##
============================================
+ Coverage 10.44% 10.45% +0.01%
- Complexity 5998 6013 +15
============================================
Files 951 951
Lines 132874 132877 +3
Branches 19329 19330 +1
============================================
+ Hits 13873 13893 +20
+ Misses 117653 117636 -17
Partials 1348 1348 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AbstractIcon to handle new replacements for AeroTech to AeroTek and MechTech to MekTek for both category and filename.
Renamed a couple of folders to bring them into compliance with usages across the rest of the codebase. It looks like a couple got renamed that shouldn't have.
Added a portrait role group for Vehicle Crew, so Vehicle Crew will now gain random portraits. Previously they were excluded, despite the portraits being available.
Closes #4898 && #4917 && #4920