Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix smart contracts api raise with nil sort type #1301

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

Naupio
Copy link
Contributor

@Naupio Naupio commented Jan 31, 2023

What problem does this PR solve?

issue: #1300

Check List

Test

  • unit test

Task

  • none

@Naupio Naupio self-assigned this Jan 31, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 31, 2023

Pull Request Test Coverage Report for Build f0230bc52265c54727e0a91052bb4a87eafb19c3-PR-1301

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 40.009%

Files with Coverage Reduction New Missed Lines %
lib/godwoken_explorer/address.ex 1 66.67%
lib/godwoken_indexer/worker/check_update_transaction_method_id_name.ex 5 0.0%
Totals Coverage Status
Change from base Build 881545ad6080a7f7e791a31e8ae023a140ce1ab8: 0.02%
Covered Lines: 2611
Relevant Lines: 6526

💛 - Coveralls

@alexsupa597
Copy link

@FrederLu
Copy link

FrederLu commented Feb 2, 2023

Page data:
https://godwoken-explorer-ui-development.vercel.app/zh-CN/contracts
According to the interface { sort_type: DESC, sort_value: EX_TX_COUNT } or { sort_type: ASC, sort_value: EX_TX_COUNT }, why can’t I get the first data item 134 of this contract’s data on the page?
image
image
image

@Naupio
Copy link
Contributor Author

Naupio commented Feb 2, 2023

Page data: https://godwoken-explorer-ui-development.vercel.app/zh-CN/contracts According to the interface { sort_type: DESC, sort_value: EX_TX_COUNT } or { sort_type: ASC, sort_value: EX_TX_COUNT }, why can’t I get the first data item 134 of this contract’s data on the page? image image image

transaction count sorter was fixed after f0230bc

@Naupio Naupio merged commit 12187c8 into Magickbase:godwoken-v1-testnet-prod Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants