Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix smart contracts api raise with nil sort type #1300

Closed
Naupio opened this issue Jan 31, 2023 · 7 comments
Closed

fix: fix smart contracts api raise with nil sort type #1300

Naupio opened this issue Jan 31, 2023 · 7 comments
Assignees

Comments

@Naupio
Copy link
Contributor

Naupio commented Jan 31, 2023

No description provided.

@Naupio Naupio self-assigned this Jan 31, 2023
@Naupio Naupio moved this from Todo to In Progress in Nervos Wallet/Explorer Jan 31, 2023
@Naupio Naupio changed the title fix: fix smart contracts api with sorter raise with nil sort type fix: fix smart contracts api raise with nil sort type Jan 31, 2023
@Naupio
Copy link
Contributor Author

Naupio commented Jan 31, 2023

before fix:
image

sorter item without sort_type

query {
  smart_contracts(input: { limit: 10, sorter: [{ sort_value: CKB_BALANCE }] }) {
    entries {
      name
      ckb_balance
    }
  }
}

@Naupio
Copy link
Contributor Author

Naupio commented Jan 31, 2023

after fixed

query {
  smart_contracts(
    input: {
      limit: 10
      sorter: [
        { sort_type: DESC, sort_value: EX_TX_COUNT }
        { sort_type: DESC, sort_value: CKB_BALANCE }
      ]
    }
  ) {
    entries {
      name
      ckb_balance
    }
  }
}

image

@Naupio
Copy link
Contributor Author

Naupio commented Jan 31, 2023

after fixed if not fill the sort type value will return this message
image

@Naupio
Copy link
Contributor Author

Naupio commented Jan 31, 2023

pr link: #1301

@alexsupa597
Copy link

@Keith-CY Keith-CY moved this from In Progress to QA in Nervos Wallet/Explorer Feb 1, 2023
@Naupio
Copy link
Contributor Author

Naupio commented Feb 4, 2023

testnet-prod was deployed @FrederLu

@FrederLu
Copy link

FrederLu commented Feb 6, 2023

Verified.

@FrederLu FrederLu moved this from QA to Production in Nervos Wallet/Explorer Feb 6, 2023
@Danie0918 Danie0918 moved this to 👀 In Review in Layer2 Explorer Feb 26, 2023
@Danie0918 Danie0918 moved this from 👀 In Review to ✅ Done in Layer2 Explorer Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Production
Development

No branches or pull requests

3 participants