Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: change the pagination to cursor and add sorter---contract list #735

Merged
merged 9 commits into from
Mar 9, 2023

Conversation

alexsupa597
Copy link
Contributor

What problem does this PR solve?

This PR is for the page of contract.

Ref: Magickbase/godwoken_explorer#556

Check List

1、sorted by balance
2、sorted by tx count

Test

e2e Test

Task

none

@vercel
Copy link

vercel bot commented Nov 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 4:32PM (UTC)

@alexsupa597 alexsupa597 changed the title change the pagination to cursor and add sorter Fix: change the pagination to cursor and add sorter Nov 20, 2022
@auto-add-label auto-add-label bot added the Fix label Nov 20, 2022
@alexsupa597
Copy link
Contributor Author

alexsupa597 commented Nov 20, 2022

@Naupio Please help to confirm whether the following parameters are correctly used on the page of contract

balance ---> ckb_balance
address ---> account--- eth_address
txcount ---> account--- transaction_count

Please also pay attention to my comment under this issue. Cause we still missing a sorter in the API of this page. If you fixed it please let me know. Thanks a lot.

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Merging #735 (6c94de6) into develop (b4b16ad) will decrease coverage by 1.08%.
The diff coverage is 2.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #735      +/-   ##
===========================================
- Coverage    67.31%   66.24%   -1.08%     
===========================================
  Files           18       18              
  Lines         1230     1250      +20     
  Branches       743      751       +8     
===========================================
  Hits           828      828              
- Misses         348      367      +19     
- Partials        54       55       +1     
Impacted Files Coverage Δ
pages/contracts.tsx 6.89% <2.63%> (-3.63%) ⬇️

@alexsupa597 alexsupa597 marked this pull request as draft November 20, 2022 10:10
@alexsupa597 alexsupa597 changed the title Fix: change the pagination to cursor and add sorter Feat: change the pagination to cursor and add sorter Nov 20, 2022
@auto-add-label auto-add-label bot added Feat and removed Fix labels Nov 20, 2022
@alexsupa597 alexsupa597 changed the title Feat: change the pagination to cursor and add sorter Feat: change the pagination to cursor and add sorter---contract list Nov 23, 2022
@Keith-CY Keith-CY marked this pull request as ready for review November 24, 2022 02:49
@Keith-CY
Copy link
Member

Keith-CY commented Nov 27, 2022

  1. There're 50 records on one page while page size is 30
    image

  2. Count of transactions is empty, null is displayed on hovering
    image

  3. Navigate to an empty list on clicking the next page

Screen.Recording.2022-11-27.at.17.55.19.mov

@Keith-CY
Copy link
Member

Keith-CY commented Dec 6, 2022

Any update on this feature

@alexsupa597 alexsupa597 marked this pull request as draft December 6, 2022 09:25
@alexsupa597
Copy link
Contributor Author

alexsupa597 commented Dec 6, 2022

1、There're 50 records on one page while page size is 30

@Keith-CY fixed.

2、Count of transactions is empty, null is displayed on hovering.

@Naupio Please have an attention to this response data.
image

3、Navigate to an empty list on clicking the next page.

@Naupio Please help to fix this error. Thanks.
image

@Naupio
Copy link

Naupio commented Dec 7, 2022

  • need add async trigger for fetch account object transaction_count subfields

@alexsupa597
Copy link
Contributor Author

alexsupa597 commented Jan 17, 2023

@Naupio Please post your PR links, if you finish the update. So, I can track it. Thanks a lot.

pages/contracts.tsx Outdated Show resolved Hide resolved
utils/handler.ts Show resolved Hide resolved
utils/handler.ts Outdated Show resolved Hide resolved
@Keith-CY Keith-CY merged commit 9a13743 into develop Mar 9, 2023
@Keith-CY Keith-CY deleted the feat/data-sorting-filtering-contract-list branch March 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants