Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve todo error #5339

Merged
merged 15 commits into from
Oct 4, 2023
Merged

Resolve todo error #5339

merged 15 commits into from
Oct 4, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Sep 26, 2023

What was the problem?

This PR resolves #5179

How was it solved?

  • Fix todo issues
  • Resolved failing unit tests

How was it tested?

  • Todo comments should be resolved and the app should be in a healthy status

@eniolam1000752 eniolam1000752 marked this pull request as ready for review September 28, 2023 15:09
@ikem-legend ikem-legend changed the title 5179 resolve todo error Resolve todo error Oct 2, 2023
@ikem-legend ikem-legend self-requested a review October 2, 2023 18:34
@eniolam1000752 eniolam1000752 requested review from ManuGowda and removed request for oskarleonard October 4, 2023 07:21
@ManuGowda ManuGowda requested review from oskarleonard and removed request for ManuGowda October 4, 2023 07:30
@eniolam1000752 eniolam1000752 merged commit ffc3b3e into release/3.0.0 Oct 4, 2023
3 checks passed
@eniolam1000752 eniolam1000752 deleted the 5179-resolve-todo-error branch October 4, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants