Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/fix the todos suggestions #5179

Closed
eniolam1000752 opened this issue Jul 17, 2023 · 0 comments
Closed

Refactor/fix the todos suggestions #5179

eniolam1000752 opened this issue Jul 17, 2023 · 0 comments
Assignees
Milestone

Comments

@eniolam1000752
Copy link
Contributor

Acceptance criteria

Below is a list of files that has valid TODOs needing fixing/refactor

  • src/modules/common/components/filterDropdownButton/selectFilter.js
  • src/modules/pos/validator/utils/getMaxAmount.js
  • src/modules/token/fungible/components/SendForm/SendForm.js (this todo should be fixed by this PR)
  • src/modules/transaction/utils/encoding.js
  • src/modules/wallet/components/signMultisigForm/form.js
  • src/modules/account/hooks/useDeprecatedAccount.js
  • src/modules/blockchainApplication/connection/components/RequestSummary/index.js
    • @todo if account doesn't exist, we should inform the user that the tx can't be signed
  • src/modules/bookmark/components/EmptyState/EmptyState.js
  • src/modules/legacy/store/middleware.js & src/modules/legacy/store/middleware.test.js
  • src/modules/settings/components/SettingDialog/settingDialog.test.js
  • src/modules/token/fungible/components/BalanceInfo/ActionBar.js
  • src/modules/token/fungible/store/reducer.js
    • Requires removal since action callback isn't used anywhere
  • src/modules/transaction/components/GenericTxParams/index.js
    • Remove todo comments as its invalid
  • src/modules/transaction/components/StakeValidate/StakeValidator.js
  • src/modules/transaction/components/TransactionTypeFigure/TransactionTypeFigure.js
  • src/modules/transaction/components/TxBroadcaster/index.js
  • src/modules/transaction/hooks/queries/useSchemas.js
    • Remove setting schema to redux store
  • src/modules/transaction/hooks/queries/useTransactions.js
  • src/modules/transaction/store/reducer.js
    • Remove todo comment as its invalid
  • src/modules/transaction/store/reducer.js
  • src/modules/wallet/components/signMultisigForm/form.js
  • src/modules/wallet/utils/hwManager.js
    • updateTransactionSignatures should be removed since its not been used anywhere in the application
  • src/redux/selectors.js
    • selectAccountBalance should be removed since its only been used in a file that would also be refactored
  • src/utils/externalLinks.js
    • Only make use of history.push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants