Resolve todo error

libs/hardwareWallet/ledger/ledgerLiskAppIPCChannel/clientLedgerHWCommunication/index.js

@@ -10,7 +10,6 @@ const {
   GET_SIGNED_MESSAGE,
 } = LEDGER_HW_IPC_CHANNELS;
 
-// TODO: remove when server have a queuing system
 function sleep(ms) {
   return new Promise((resolve) => setTimeout(resolve, ms));
 }

setup/jest.config.js

@@ -152,7 +152,6 @@ module.exports = {
     'src/modules/pos/validator/store/reducers/staking.js',
     'src/modules/transaction/components/TransactionResult/illustrationsMap.js',
     'src/modules/transaction/components/Regular/Regular.js',
-    'src/modules/token/fungible/components/BalanceInfo/EmptyBalanceTooltipWrapper.js',
     'src/modules/wallet/utils/api/index.js',
     'src/modules/transaction/utils/hwManager/index.js',
     'src/modules/transaction/utils/transactionDetailsHelper.js',

src/locales/en/common.json

@@ -29,7 +29,6 @@
   "Add message (Optional)": "Add message (Optional)",
   "Add network": "Add network",
   "Add new": "Add new",
-  "Add to stakes": "Add to stakes",
   "Add to staking queue": "Add to staking queue",
   "Add to watched": "Add to watched",
   "Add your account": "Add your account",
@@ -578,8 +577,6 @@
   "Send": "Send",
   "Send a reclaim transaction": "Send a reclaim transaction",
   "Send tokens": "Send tokens",
-  "Send {{token}}": "Send {{token}}",
-  "Send {{token}} here": "Send {{token}} here",
   "Sender": "Sender",
   "Sender account: ": "Sender account: ",
   "Sender address": "Sender address",
@@ -609,7 +606,6 @@
   "Stake added to queue": "Stake added to queue",
   "Stake amount": "Stake amount",
   "Stake amount can't be zero or negative.": "Stake amount can't be zero or negative.",
-  "Stake for validator": "Stake for validator",
   "Stake now": "Stake now",
   "Stake validator": "Stake validator",
   "Staked": "Staked",
@@ -687,7 +683,7 @@
   "This transaction was initiated from another application for signature request.": "This transaction was initiated from another application for signature request.",
   "This validator has been permanently banned": "This validator has been permanently banned",
   "This validator is among the first 101 validators by validator weight.": "This validator is among the first 101 validators by validator weight.",
-  "This validator is among the first 101 validators in validator weight ranking.": "This validator is among the first 101 validators in validator weight ranking.",
+  "This validator is among the first {{roundLength}} validators in validator weight ranking.": "This validator is among the first {{roundLength}} validators in validator weight ranking.",
   "This validator will be punished in upcoming rounds": "This validator will be punished in upcoming rounds",
   "To": "To",
   "To application": "To application",
@@ -796,7 +792,6 @@
   "You can now download your encrypted secret recovery phrase and use it to add your account on other devices.": "You can now download your encrypted secret recovery phrase and use it to add your account on other devices.",
   "You can only stake in multiplies of 10 LSK.": "You can only stake in multiplies of 10 LSK.",
   "You can see a list of your applications on the network dropdown.": "You can see a list of your applications on the network dropdown.",
-  "You cannot stake for this validator": "You cannot stake for this validator",
   "You do not have any bookmarks yet.": "You do not have any bookmarks yet.",
   "You do not have any tokens yet.": "You do not have any tokens yet.",
   "You have cancelled the transaction on your hardware wallet.": "You have cancelled the transaction on your hardware wallet.",

src/modules/account/hooks/useDeprecatedAccount.js

@@ -13,16 +13,14 @@ const defaultAccount = {
     address: '',
     publicKey: '',
     legacyAddress: '',
-    // @todo Replace mock balance value once we have the balance in the account store
-    balance: '10000000000000',
+    balance: '0',
     username: '',
     isMigrated: true,
     isValidator: false,
     isMultisignature: false,
   },
-  // @todo same here.
   token: {
-    balance: '10000000000000',
+    balance: '0',
     tokenID: '00000000',
   },
   sequence: {

src/modules/blockchainApplication/connection/components/RequestSummary/index.js

@@ -1,6 +1,5 @@
 /* eslint-disable max-lines */
 /* eslint-disable complexity */
-/* istanbul ignore file */ // @todo Add unit tests by #4824
 import React, { useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import classNames from 'classnames';

src/modules/bookmark/components/BookmarksListModal/BookmarkListModal.js

@@ -6,7 +6,6 @@ import ModalWrapper from '@bookmark/components/BookmarksListModal/BookmarkModalW
 import styles from '@bookmark/components/BookmarksListModal/BookmarkListModal.css';
 
 const Bookmarks = ({ bookmarks, token, t, bookmarkRemoved, bookmarkUpdated }) => {
-  // TODO: Refactor manager component for bookmark list
   const history = useHistory();
   return (
     <ModalWrapper>

src/modules/common/components/bars/topBar/stakeQueueToggle.js

@@ -1,4 +1,3 @@
-// @todo: this should be re-instated when the issue with lisk-client is fixed
 /* istanbul ignore file */
 import React from 'react';
 import Tooltip from 'src/theme/Tooltip';

src/modules/common/components/filterDropdownButton/filters.css

@@ -4,6 +4,11 @@
   display: flex;
   flex-direction: column;
 
+  & > div > div {
+    max-height: 300px;
+    overflow-y: auto;
+  }
+
   & .fieldLabel {
     @mixin contentNormal;
 

src/modules/common/components/filterDropdownButton/selectFilter.js

@@ -1,9 +1,9 @@
 import React from 'react';
 import classNames from 'classnames';
 import { withTranslation } from 'react-i18next';
-import { MODULE_COMMANDS_NAME_MAP } from 'src/modules/transaction/configuration/moduleCommand';
 import { getModuleCommandTitle } from 'src/modules/transaction/utils/moduleCommand';
 import Select from 'src/theme/Select';
+import { useCommandSchema } from '@network/hooks';
 import styles from './filters.css';
 
 const SelectFilter = ({
@@ -15,12 +15,15 @@ const SelectFilter = ({
   name,
   updateCustomFilters,
 }) => {
-  // TODO: This logic is static, different blockchain application can have different commands
-  // We need this logic to be dynamic based on selected chain.
-  const options = Object.keys(MODULE_COMMANDS_NAME_MAP).map((key) => ({
-    value: MODULE_COMMANDS_NAME_MAP[key],
-    label: getModuleCommandTitle()[MODULE_COMMANDS_NAME_MAP[key]],
+  const { moduleCommandSchemas, isLoading } = useCommandSchema();
+
+  if (isLoading) return null;
+
+  const options = Object.keys(moduleCommandSchemas).map((key) => ({
+    value: key,
+    label: getModuleCommandTitle()[key],
   }));
+
   options.unshift({ value: '', label: placeholder });
 
   const onChange = (value) => {

src/modules/common/components/filterDropdownButton/selectFilter.test.js

@@ -1,6 +1,10 @@
 import React from 'react';
 import { mount } from 'enzyme';
+import { useCommandSchema } from '@network/hooks';
 import SelectFilter from './selectFilter';
+import { mockCommandParametersSchemas } from '../../__fixtures__';
+
+jest.mock('@network/hooks/useCommandsSchema');
 
 describe('SelectFilter', () => {
   const props = {
@@ -14,10 +18,30 @@ describe('SelectFilter', () => {
     label: 'Type',
   };
 
+  useCommandSchema.mockReturnValue({
+    moduleCommandSchemas: mockCommandParametersSchemas.data.commands.reduce(
+      (result, { moduleCommand, schema }) => ({ ...result, [moduleCommand]: schema }),
+      {}
+    ),
+  });
+
   it('should handle input selection', () => {
     const wrapper = mount(<SelectFilter {...props} />);
     wrapper.find('Select.input').simulate('click');
     wrapper.find('span.option').at(0).simulate('click');
     expect(props.updateCustomFilters).toBeCalled();
   });
+
+  it('should not render the component while loading', () => {
+    useCommandSchema.mockReturnValue({
+      isLoading: true,
+      moduleCommandSchemas: mockCommandParametersSchemas.data.commands.reduce(
+        (result, { moduleCommand, schema }) => ({ ...result, [moduleCommand]: schema }),
+        {}
+      ),
+    });
+
+    const wrapper = mount(<SelectFilter {...props} />);
+    expect(wrapper.find('.fieldGroup').exists()).toBeFalsy();
+  });
 });

src/modules/legacy/components/Summary/Summary.js

@@ -78,10 +78,4 @@ const Summary = ({ balanceReclaimed, nextStep, wallet, t, fees }) => {
   );
 };
 
-// istanbul ignore next
-const areEqual = (
-  prevProps,
-  nextProps // @todo account has multiple balance now
-) => prevProps.wallet.summary.balance === nextProps.wallet.summary.balance;
-
-export default React.memo(Summary, areEqual);
+export default Summary;

src/modules/pos/validator/components/ValidatorSummary/ValidatorSummary.js

@@ -11,10 +11,13 @@ import { PrimaryButton } from 'src/theme/buttons';
 import DialogLink from 'src/theme/dialog/link';
 import styles from './ValidatorSummary.css';
 import { convertCommissionToPercentage } from '../../utils';
+import { usePosConstants } from '../../hooks/queries';
 
 const ValidatorSummary = ({ validator, status, weight }) => {
   const { address, name, rank, commission, nextAllocatedTime } = validator;
   const { t } = useTranslation();
+  const { data: posConstants } = usePosConstants();
+  const roundLength = posConstants?.data?.roundLength || '-';
 
   return (
     <Box className={styles.wrapper}>
@@ -36,8 +39,12 @@ const ValidatorSummary = ({ validator, status, weight }) => {
         </div>
       </BoxHeader>
       <BoxContent>
-        {/* @Todo: the value of roundLength should be dynamically integrated from the usePosConstants query hook which would be addressed in issue #4502 */}
-        <p>{t('This validator is among the first 101 validators in validator weight ranking.')}</p>
+        <p>
+          {t(
+            'This validator is among the first {{roundLength}} validators in validator weight ranking.',
+            { roundLength }
+          )}
+        </p>
         <div className={styles.summaryDetails}>
           <div>
             <span>

src/modules/pos/validator/components/ValidatorSummary/ValidatorSummary.test.js

@@ -5,6 +5,8 @@ import { screen } from '@testing-library/react';
 import { mockValidators } from '../../__fixtures__';
 import ValidatorSummary from './ValidatorSummary';
 import { convertCommissionToPercentage } from '../../utils';
+import { mockPosConstants } from '../../__fixtures__/mockPosConstants';
+import { usePosConstants } from '../../hooks/queries';
 
 jest.mock('react-i18next', () => ({
   ...jest.requireActual('react-i18next'),
@@ -13,6 +15,8 @@ jest.mock('react-i18next', () => ({
   }),
 }));
 
+jest.mock('../../hooks/queries/usePosConstants');
+
 describe('ValidatorSummary', () => {
   let wrapper;
   const props = {
@@ -22,6 +26,8 @@ describe('ValidatorSummary', () => {
     lastGeneratedTime: 23293993234,
   };
 
+  usePosConstants.mockReturnValue({ data: mockPosConstants });
+
   beforeEach(() => {
     jest.clearAllMocks();
     wrapper = renderWithRouter(ValidatorSummary, props);
@@ -30,7 +36,7 @@ describe('ValidatorSummary', () => {
   it('should display properly', () => {
     expect(
       screen.getByText(
-        'This validator is among the first 101 validators in validator weight ranking.'
+        'This validator is among the first {{roundLength}} validators in validator weight ranking.'
       )
     ).toBeTruthy();
     expect(screen.getByText('Commission :')).toBeTruthy();
@@ -53,4 +59,20 @@ describe('ValidatorSummary', () => {
     );
     expect(screen.getByText('Stake')).toHaveAttribute('disabled');
   });
+
+  it('should return - when roundLength is not available', () => {
+    usePosConstants.mockReturnValue({ data: {} });
+
+    wrapper.rerender(
+      <MemoryRouter>
+        <ValidatorSummary {...props} />
+      </MemoryRouter>
+    );
+
+    expect(
+      screen.getByText(
+        'This validator is among the first {{roundLength}} validators in validator weight ranking.'
+      )
+    ).toBeTruthy();
+  });
 });

src/modules/pos/validator/components/ValidatorsTable/ValidatorRow.test.js

@@ -5,9 +5,12 @@ import { addedToWatchList, removedFromWatchList } from 'src/redux/actions';
 import { mockAppsTokens } from '@token/fungible/__fixtures__';
 import usePosToken from '@pos/validator/hooks/usePosToken';
 import ValidatorRow from './ValidatorRow';
+import { usePosConstants } from '../../hooks/queries';
+import { mockPosConstants } from '../../__fixtures__/mockPosConstants';
 
 jest.mock('src/redux/actions');
 jest.mock('@pos/validator/hooks/usePosToken');
+jest.mock('../../hooks/queries/usePosConstants');
 
 let wrapper;
 const props = {
@@ -38,6 +41,7 @@ const props = {
 };
 
 usePosToken.mockReturnValue({ token: mockAppsTokens.data[0] });
+usePosConstants.mockReturnValue({ data: mockPosConstants });
 
 describe('ValidatorRow', () => {
   it('adds validators to watch list when watch icon is clicked', () => {

src/modules/pos/validator/hooks/queries/usePosConstants.js

@@ -15,7 +15,6 @@ export const usePosConstants = ({ config: customConfig = {}, options } = {}) =>
     ...customConfig,
   };
 
-  // @TODO: we need to change the caching time from 5mins to something larger since this is a constant that doesn't frequently change
   return useCustomQuery({
     keys: [POS_CONSTANTS],
     config,