Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The production build is broken due to the refactoring changes #4320

Closed
Tracked by #4033
reyraa opened this issue May 24, 2022 · 1 comment · Fixed by #4327
Closed
Tracked by #4033

The production build is broken due to the refactoring changes #4320

reyraa opened this issue May 24, 2022 · 1 comment · Fixed by #4327
Assignees
@reyraa
Labels
type: bug
Milestone
Sprint 75

Comments

@reyraa
Copy link
Contributor

reyraa commented May 24, 2022 •
edited
Loading

Expected behavior

Due to changes done by #4033 the production build has stopped working. In order to re-instate the e2e tests, and being able to prepare test releases, we should get the production build working asap.

Actual behavior

The production build runs without errors, but the prepared asset doesn't run successfully.

Steps to reproduce

  • Run npm run pack.
  • Run the app.
@reyraa reyraa self-assigned this May 24, 2022
@sridharmeganathan sridharmeganathan added this to the Sprint 75 milestone May 24, 2022
@sridharmeganathan sridharmeganathan mentioned this issue May 24, 2022
Closed
24 tasks
@reyraa reyraa mentioned this issue May 25, 2022
Merged
reyraa added a commit that referenced this issue May 25, 2022
@reyraa
Merge pull request #4327 from LiskHQ/4320-fix-production-build
22c0ae6 
 The production build is broken due to the refactoring changes - Closes #4320
@reyraa
Copy link
Contributor Author

reyraa commented May 25, 2022

Closed by #4327

@reyraa reyraa closed this as completed May 25, 2022
Repository owner moved this from Backlog to Done in Lisk Desktop Version 3.0.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
type: bug
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 75
Development

Successfully merging a pull request may close this issue.

The production build is broken due to the refactoring changes - Closes #4320 LiskHQ/lisk-desktop
2 participants
@reyraa @sridharmeganathan