The production build is broken due to the refactoring changes - Closes #4320 #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
changed the base branch from
development
to
feature/blockchain-agnostic-new
reyraa
force-pushed
the
4320-fix-production-build
branch
from
6521866 to
20d33bc
Compare
reyraa
force-pushed
the
4320-fix-production-build
branch
from
01031a1 to
4c1dfa9
Compare
ManuGowda
suggested changes
May 25, 2022
| "postcss-for": "=2.1.1", | ||
| "postcss-functions": "3.0.0", | ||
| "postcss-loader": "3.0.0", | ||
| "postcss-mixins": "6.2.1", |
There was a problem hiding this comment.
why some deps version are lowered?
ManuGowda
approved these changes
May 25, 2022
ikem-legend
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4320
How was it solved?
Fixed the production build setup, as well as the issue with the package lock file.
How was it tested?
npm cishould work.npm ishould work.npm run dev.npm run buildand then run it using a local server. for examplehttp-server ./app/build.npm run pack, ornpm run pack:win.