Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Merge release/6.0.0 into release/6.1.0 #9123

Merged
merged 53 commits into from
Nov 1, 2023
Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 24, 2023

Description

Merge release/6.0.0 branch into release/6.1.0 branch

has5aan and others added 30 commits September 11, 2023 23:57
* Adds defaultCommission to PoSEndpoint.getConstants reponse

* Adds response schema for pos_getConstants endpoint
🐛 Passphrase encryption consumes options.kdf.params.iterations if provided
…schema (#9016)

Updates DynamicRewardEndpoint.getExpectedValidatorRewards request and response schema
* ♻️  Manage different file paths #9013 and 🌱 add export-json flag #9019

* 💅🏻 Improve var handling and prettify json
⬆️ Update lisk-db version
* ♻️ Update PoS constants

* ✅ Fix test for _updateProductivity

---------

Co-authored-by: shuse2 <shuse2@users.noreply.github.com>
…9026)

🐛 Fix reward distribution to use # of validators instead of constant
🌱 Add --add-legacy flag to keys create
* Updates TokenInteroperableMethod.recover to validate storeValue

* ♻️ ✅  TokenInteroperableMethod.recover
* Update verifyValidatorsUpdate logic

* Update test

---------

Co-authored-by: Mitsuaki Uchimoto <mitsuaki-u@users.noreply.github.com>
* 🐛 Fix genesis block aggregate commit

* Update elements/lisk-chain/src/block_header.ts

Co-authored-by: !shan <ishantiw.quasar@gmail.com>

* ✅ Fix unit test

---------

Co-authored-by: !shan <ishantiw.quasar@gmail.com>
Co-authored-by: shuse2 <shuse2@users.noreply.github.com>
* 🐛 Update IPC timeout

* 💅 Fix variable name
* 🐛 Update getMaxRemovalHeight to start from minCerifyHeight - 1

* 🐛 Add maxRemovalHeight handling when finalizing a new height

* ✅ Fix additional check and fix description
* 🐛 Fix outdated getMaxRemovalHeight

* ♻️ Fix test description
* ♻️ Fix legacy DB keys and encode/decode

* ♻️  Improve syncing process
- Add snapshotBlockID in requestSchema
- Use bracketInfo to respond with legacyBlocks
- Add legacyChainBracketInfoExist storage api
- Fix tests and add test for getLegacyBrackets endpoint

* 🐛 Fix schema prop name blockId->blockID

* ♻️ Fix legacy request schema

* ♻️ Fix legacy sync issue

* ♻️ Improve FailAndAttemptSyncError handling

* ♻️ Update legacy sync handler flow
- Fix storage bug related to getTransactionsByBlockID
- Handle timeouts
- Handler errors

* ♻️ Update improve sync timeouts

* 💅Improve naming and format

* ✅ Fix and improve tests
…ing generator (#9069)

* 🌱 Add keys information to status

* 🐛 Fix single commits when enabling generator

* 🐛 remove unused metrics
* Fix validator being unshuffled by the engine

* Add config option to prevent validator shuffling before a certain block height

* Test array equality using toEqual

Co-authored-by: !shan <ishantiw.quasar@gmail.com>

* Move delayed shuffle validator option to exceptions

* Add an intermediate step when sorting the validator list

* Add test case when validators are expected not to be shuffled

* Adapt consensus unit test

* Update application snapshot

---------

Co-authored-by: !shan <ishantiw.quasar@gmail.com>
🐛 Fix unintended removal of element
Fix Monitor Plugin getTransactionStats
…9079)

* _verifyTerminatedStateAccountsCommon doesn't need to be inside loop

* Apply review comments

* Use util functions & apply performance steps to avoid extra loops

* Use BigInt

* Refactor to avoid loop

* Update genesis block

* Update chainID

---------

Co-authored-by: !shan <ishantiw.quasar@gmail.com>
Fix misleading offline signing error message
💅 Remove unnecessary exceptions
@shuse2 shuse2 requested review from Phanco and sitetester October 27, 2023 07:52
@shuse2 shuse2 requested a review from sitetester October 30, 2023 08:34
Copy link
Contributor

@sitetester sitetester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate test it('should call _verifyTerminatedStateAccountsIDs', in framework/test/unit/modules/interoperability/mainchain/module.spec.ts

@shuse2 shuse2 requested a review from sitetester October 30, 2023 15:09
Copy link
Contributor

@sitetester sitetester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the test on line 578 needs to be removed, since the deleted one is at the right place per code execution

@shuse2 shuse2 requested a review from sitetester October 30, 2023 22:32
@shuse2 shuse2 requested a review from sitetester October 31, 2023 15:02
Tschakki and others added 2 commits November 1, 2023 10:13
* Update mainchain_registration.ts

* Update variable

* Update variable names

* Clean up react module

* Update hello module

* Update schemas

* Align variables names

* Remove unused method

* Move up members

* Add comments

* Fix error
@shuse2 shuse2 requested a review from sitetester November 1, 2023 14:48
@shuse2 shuse2 force-pushed the merge-6.0.0-into-6.1.0 branch from 8d80722 to 64f162a Compare November 1, 2023 15:03
@shuse2 shuse2 force-pushed the merge-6.0.0-into-6.1.0 branch from c2016e9 to dcb7d10 Compare November 1, 2023 15:15
@shuse2 shuse2 merged commit 773ba74 into release/6.1.0 Nov 1, 2023
10 checks passed
@shuse2 shuse2 deleted the merge-6.0.0-into-6.1.0 branch November 1, 2023 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants