This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Merge release/6.0.0 into release/6.1.0 #9123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds defaultCommission to PoSEndpoint.getConstants reponse * Adds response schema for pos_getConstants endpoint
🐛 Passphrase encryption consumes options.kdf.params.iterations if provided
…schema (#9016) Updates DynamicRewardEndpoint.getExpectedValidatorRewards request and response schema
⬆️ Update lisk-db version
* ♻️ Update PoS constants * ✅ Fix test for _updateProductivity --------- Co-authored-by: shuse2 <shuse2@users.noreply.github.com>
…9026) 🐛 Fix reward distribution to use # of validators instead of constant
🌱 Add --add-legacy flag to keys create
* Updates TokenInteroperableMethod.recover to validate storeValue * ♻️ ✅ TokenInteroperableMethod.recover
* Update verifyValidatorsUpdate logic * Update test --------- Co-authored-by: Mitsuaki Uchimoto <mitsuaki-u@users.noreply.github.com>
* 🐛 Fix genesis block aggregate commit * Update elements/lisk-chain/src/block_header.ts Co-authored-by: !shan <ishantiw.quasar@gmail.com> * ✅ Fix unit test --------- Co-authored-by: !shan <ishantiw.quasar@gmail.com>
Co-authored-by: shuse2 <shuse2@users.noreply.github.com>
* 🐛 Update IPC timeout * 💅 Fix variable name
* 🐛 Update getMaxRemovalHeight to start from minCerifyHeight - 1 * 🐛 Add maxRemovalHeight handling when finalizing a new height * ✅ Fix additional check and fix description
* 🐛 Fix outdated getMaxRemovalHeight * ♻️ Fix test description
* ♻️ Fix legacy DB keys and encode/decode * ♻️ Improve syncing process - Add snapshotBlockID in requestSchema - Use bracketInfo to respond with legacyBlocks - Add legacyChainBracketInfoExist storage api - Fix tests and add test for getLegacyBrackets endpoint * 🐛 Fix schema prop name blockId->blockID * ♻️ Fix legacy request schema * ♻️ Fix legacy sync issue * ♻️ Improve FailAndAttemptSyncError handling * ♻️ Update legacy sync handler flow - Fix storage bug related to getTransactionsByBlockID - Handle timeouts - Handler errors * ♻️ Update improve sync timeouts * 💅Improve naming and format * ✅ Fix and improve tests
…ing generator (#9069) * 🌱 Add keys information to status * 🐛 Fix single commits when enabling generator * 🐛 remove unused metrics
* Fix validator being unshuffled by the engine * Add config option to prevent validator shuffling before a certain block height * Test array equality using toEqual Co-authored-by: !shan <ishantiw.quasar@gmail.com> * Move delayed shuffle validator option to exceptions * Add an intermediate step when sorting the validator list * Add test case when validators are expected not to be shuffled * Adapt consensus unit test * Update application snapshot --------- Co-authored-by: !shan <ishantiw.quasar@gmail.com>
🐛 Fix unintended removal of element
Fix Monitor Plugin getTransactionStats
…9079) * _verifyTerminatedStateAccountsCommon doesn't need to be inside loop * Apply review comments * Use util functions & apply performance steps to avoid extra loops * Use BigInt * Refactor to avoid loop * Update genesis block * Update chainID --------- Co-authored-by: !shan <ishantiw.quasar@gmail.com>
Fix misleading offline signing error message
💅 Remove unnecessary exceptions
sitetester
suggested changes
Oct 27, 2023
sitetester
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a duplicate test it('should call _verifyTerminatedStateAccountsIDs',
in framework/test/unit/modules/interoperability/mainchain/module.spec.ts
sitetester
suggested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the test on line 578 needs to be removed, since the deleted one is at the right place per code execution
This reverts commit 9a6063f.
sitetester
suggested changes
Oct 31, 2023
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
suggested changes
Oct 31, 2023
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
suggested changes
Oct 31, 2023
sitetester
suggested changes
Oct 31, 2023
* Update mainchain_registration.ts * Update variable * Update variable names * Clean up react module * Update hello module * Update schemas * Align variables names * Remove unused method * Move up members * Add comments * Fix error
…to merge-6.0.0-into-6.1.0
…to merge-6.0.0-into-6.1.0
shuse2
force-pushed
the
merge-6.0.0-into-6.1.0
branch
from
November 1, 2023 15:03
8d80722
to
64f162a
Compare
shuse2
force-pushed
the
merge-6.0.0-into-6.1.0
branch
from
November 1, 2023 15:15
c2016e9
to
dcb7d10
Compare
Phanco
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge release/6.0.0 branch into release/6.1.0 branch