Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix outdated getMaxRemovalHeight #9065

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 5, 2023

What was the problem?

This PR resolves #9064

How was it solved?

  • Remove duplicate getMaxRemovalHeight implementation
  • Move test to the main implementation spec

How was it tested?

  • Updated test

@shuse2 shuse2 requested review from ishantiw and Phanco October 5, 2023 20:58
@shuse2 shuse2 self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #9065 (167a78c) into release/6.0.0 (196c9ec) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #9065      +/-   ##
=================================================
- Coverage          83.52%   83.52%   -0.01%     
=================================================
  Files                603      603              
  Lines              22672    22671       -1     
  Branches            3348     3348              
=================================================
- Hits               18937    18936       -1     
  Misses              3735     3735              
Files Coverage Δ
...ne/consensus/certificate_generation/commit_pool.ts 93.98% <100.00%> (ø)
framework/src/engine/consensus/consensus.ts 82.68% <100.00%> (-0.05%) ⬇️

@shuse2 shuse2 merged commit da598fb into release/6.0.0 Oct 6, 2023
11 checks passed
@shuse2 shuse2 deleted the 9064-fix-max-removal-height branch October 6, 2023 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants