Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add keys info to generator:status and create singleCommits when enabling generator #9069

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 6, 2023

What was the problem?

This PR resolves #9068 and resolves #9067

How was it solved?

  • Add generatorKey and blsKey information when returning generator_getStatus
  • Update to create singleCommits when calling generator_updateStatus

How was it tested?

  • Call generator_getStatus and see the response
  • Call generator_updateStatus with generator which has encrypted keys and observe log
  • Ensure the logic did not change for creating singleCommits

@shuse2 shuse2 self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #9069 (da8747b) into release/6.0.0 (c589442) will increase coverage by 0.01%.
The diff coverage is 97.01%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #9069      +/-   ##
=================================================
+ Coverage          83.45%   83.47%   +0.01%     
=================================================
  Files                603      604       +1     
  Lines              22770    22803      +33     
  Branches            3360     3364       +4     
=================================================
+ Hits               19003    19035      +32     
- Misses              3767     3768       +1     
Files Coverage Δ
framework/src/engine/generator/endpoint.ts 96.72% <100.00%> (+0.14%) ⬆️
framework/src/engine/generator/generator.ts 81.88% <100.00%> (-1.85%) ⬇️
framework/src/engine/generator/schemas.ts 100.00% <ø> (ø)
...work/src/engine/generator/single_commit_handler.ts 96.55% <96.55%> (ø)

... and 1 file with indirect coverage changes

@ishantiw ishantiw merged commit a420fcd into release/6.0.0 Oct 6, 2023
11 checks passed
@ishantiw ishantiw deleted the 9067-add-keys-info branch October 6, 2023 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants