Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lin 425 add artifact delete functionality #676

Closed
wants to merge 12 commits into from

Commits on Jun 1, 2022

  1. Add delete function to API

    Remove an artifact from artifact store as well as
    removing value from both database and pickle store if
    no other artifacts refer to it.
    LordDarkula committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    650219d View commit details
    Browse the repository at this point in the history
  2. Remove ArtifactDeleteException custom exception

    A KeyError can be raised instead when the pickle file is not found at
    the expected location.
    LordDarkula committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c21bc63 View commit details
    Browse the repository at this point in the history
  3. Write end to end tests for artifact delete

    There might be a bug with artifact versions so the tests with hardcoded
    versions are xfailed.
    LordDarkula committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4f10dfb View commit details
    Browse the repository at this point in the history
  4. Fix isort

    LordDarkula committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    32bbfd7 View commit details
    Browse the repository at this point in the history
  5. Add all option to delete API call

    Allow user to pass in all as a string into the version parameter
    of delete to delete all versions of an artifact.
    LordDarkula committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    098ec15 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Fixing pytorch dependencies for integration tests (#661)

    * Fixing pytorch dependencies for integration tests
    
    * Fixing comments for pytorch integration tests
    aayan636 authored and LordDarkula committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    cc5a31a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    ed0f41f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Configuration menu
    Copy the full SHA
    61a49f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5976ca6 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    f0ef688 View commit details
    Browse the repository at this point in the history
  2. Validate version before deleting artifact

    Write is_artifact_version_valid to validate version passed in by user.
    Make version a mandatory keyword argument in lineapy.delete API call.
    Fix bug in which version was being set to latest when version 0 was
    passeed in.
    Cast numeric string version to int.
    LordDarkula committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    127356b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Update unit tests

    Add version flags to delete calls in tests.
    LordDarkula committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c6f08fe View commit details
    Browse the repository at this point in the history