Lin 425 add artifact delete functionality #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an artifact from artifact store as well as removing value from both database and pickle store if no other artifacts refer to it.
A KeyError can be raised instead when the pickle file is not found at the expected location.
There might be a bug with artifact versions so the tests with hardcoded versions are xfailed.
Allow user to pass in all as a string into the version parameter of delete to delete all versions of an artifact.
* Fixing pytorch dependencies for integration tests * Fixing comments for pytorch integration tests
Write is_artifact_version_valid to validate version passed in by user. Make version a mandatory keyword argument in lineapy.delete API call. Fix bug in which version was being set to latest when version 0 was passeed in. Cast numeric string version to int.
Add version flags to delete calls in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?