Fix xfail in test_linea_api.py #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanwu
approved these changes
Jun 3, 2022
| @@ -138,17 +137,16 @@ def test_delete_artifact_version(execute): | |||
| catalog = lineapy.catalog() | |||
| versions = [x._version for x in catalog.artifacts if x.name=='x'] | |||
| num_versions = len(versions) | |||
|
|
|||
| x_retrieve = lineapy.get('x').get_value() | |||
There was a problem hiding this comment.
This is fine, but we can also add accessing artifacts in the TracerContext (which the fixture is using).
It already is accessing artifacts in the following code.
def slice(self, name: str) -> str:
artifact = self.db.get_artifact_by_name(name)
return str(get_program_slice(self.graph, [artifact.node_id]))
|
|
||
| # We want to Delete version 1, but the code is executed twice in testing, causing no version 1 to be deleted in second execution |
There was a problem hiding this comment.
We should figure out if this needs to be fixed.
yifanwu
pushed a commit
that referenced
this pull request
Jun 5, 2022
* Add delete function to API Remove an artifact from artifact store as well as removing value from both database and pickle store if no other artifacts refer to it. * Remove ArtifactDeleteException custom exception A KeyError can be raised instead when the pickle file is not found at the expected location. * Write end to end tests for artifact delete There might be a bug with artifact versions so the tests with hardcoded versions are xfailed. * Fix isort * Add all option to delete API call Allow user to pass in all as a string into the version parameter of delete to delete all versions of an artifact. * Fixing pytorch dependencies for integration tests (#661) * Fixing pytorch dependencies for integration tests * Fixing comments for pytorch integration tests * Fix xfail in test_linea_api.py (#667) * Fix merged to main branch issue Co-authored-by: Aayan Kumar <aayan.kumar123@gmail.com> Co-authored-by: Mingjer Lee <mingjerli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two reasons causing these two xfail test cases.
Fixes # (issue)
Two xfail in test_linea_api.py
Type of change
Please delete options that are not relevant.
How Has This Been Tested?