Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade for CMT delays #7206

Merged

Commits on Apr 13, 2024

  1. Add upgrade for CMT delays

    Add an upgrade routine for CMT delays. This fix will only work in conjunction with a fix in the CMT delay itself.
    
    The CMT delay uses `sprintf` calls to generate the technical names and display names of the delays. These calls are locale dependent. As a consequence for example the feedback delay might have been saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma) in a save file.
    
    The CMT fix makes sure that all delays use points in their names. Therefore we must upgrade all names that contain commas to ones that contain points.
    michaelgregorius committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    c2ff2d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Code review changes

    * Static map
    * Braces around continue
    * Make const_iterator itself const as well
    * Remove output
    michaelgregorius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    e1899d8 View commit details
    Browse the repository at this point in the history
  2. Bump CMT to d8bf8084aa3

    Bump the CMT submodule to commit d8bf8084aa3 which contains the fixes for issue LMMS#5167. The delays now always report the same name strings.
    michaelgregorius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0e3ee2f View commit details
    Browse the repository at this point in the history
  3. More code review changes

    * Map is now const and initialized iIn place
    * Use `constFind` and `constEnd` when searching for an element
    michaelgregorius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    564f50f View commit details
    Browse the repository at this point in the history