Add upgrade for CMT delays #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an upgrade routine for CMT delays. This fix will only work in conjunction with a fix in the CMT delay itself. The CMT delay uses `sprintf` calls to generate the technical names and display names of the delays. These calls are locale dependent. As a consequence for example the feedback delay might have been saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma) in a save file. The CMT fix makes sure that all delays use points in their names. Therefore we must upgrade all names that contain commas to ones that contain points.
Veratil
reviewed
Apr 13, 2024
|
@michaelgregorius I merged the CMT PR. You can update the submodule in this PR as well. |
* Static map * Braces around continue * Make const_iterator itself const as well * Remove output
Bump the CMT submodule to commit d8bf8084aa3 which contains the fixes for issue LMMS#5167. The delays now always report the same name strings.
Thanks @PhysSong! I have bumped the version of the CMT submodule with commit 0e3ee2f. So this PR should be ready to go now. |
Veratil
reviewed
Apr 14, 2024
* Map is now const and initialized iIn place * Use `constFind` and `constEnd` when searching for an element
Veratil
approved these changes
Apr 14, 2024
|
Be sure to update the PR title to upgrading CMT submodule too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an upgrade routine for CMT delays. This fix will only work in conjunction with a fix in the CMT delay itself.
The CMT delay uses
sprintfcalls to generate the technical names and display names of the delays. These calls are locale dependent. As a consequence for example the feedback delay might have been saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma) in a save file.The CMT fix makes sure that all delays use points in their names. Therefore we must upgrade all names that contain commas to ones that contain points.
This pull request must only be merged once LMMS/cmt#6 is merged so that the the LMMS CMT submodule can be bumped to the corresponding commit.