Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown LADSPA plugin fbdelay_0.1s #5167

Closed
DanielChabrowski opened this issue Sep 3, 2019 · 14 comments · Fixed by #7206
Closed

Unknown LADSPA plugin fbdelay_0.1s #5167

DanielChabrowski opened this issue Sep 3, 2019 · 14 comments · Fixed by #7206
Labels
bug

Comments

@DanielChabrowski
Copy link

OS: xubuntu 19.04
lmms-1.2.0-linux-x86_64.AppImage

The following happens after opening "Thalendric - Armageddon" demo:

The following errors occured while loading: 
Unknown LADSPA plugin fbdelay_0.1s requested.
Unknown LADSPA plugin fbdelay_0.1s requested.

Even though the effect is visible and should be provided by CMT:
Screenshot_2019-09-03_22-24-13
@zonkmachine zonkmachine added the bug label Sep 4, 2019
@zonkmachine
Copy link
Contributor

zonkmachine commented Sep 4, 2019 •
edited
Loading

If you save that project as an mmp and change "fbdelay_0.1s" to "fbdelay_0,1s" it will open correctly.

@zonkmachine
Copy link
Contributor

This issue is present already on lmms-1.0.3

@PhysSong
Copy link
Member

PhysSong commented Sep 5, 2019

It seems like CMT plugins use locale-dependent sprintf function to generate the plugin descriptor. Since LMMS relies on the label of the LADSPA plugin descriptor, the local dependence becomes a problem.
However, I'm still not sure how to handle this issue...

@DanielChabrowski
Copy link
Author

Running export LC_NUMERIC=en_US.UTF-8 before lmms is a possible workaround if someone is dying to listen to this demo in its full glory.

@zonkmachine
Copy link
Contributor

upstream

It looks like CMT isn't managed upstream anywhere today so we may have to hack around this here. See comment in issue #3963
warning Very old. No upstream VCS. Available as a tarball only. May need to fork.

@PhysSong PhysSong removed the upstream label Sep 8, 2019
@trebmuh
Copy link
Contributor

trebmuh commented Sep 8, 2019 •
edited
Loading

CMT had a release in January this year. See there.

@Rossmaxx
Copy link
Contributor

CMT had a release in January this year. See there.

Did this fix the issue? Can anyone confirm.

If not, is it fine to manually tweak the mmp?

@zonkmachine
Copy link
Contributor

Did this fix the issue? Can anyone confirm.

Did you open "Thalendric - Armageddon" ?

If not, is it fine to manually tweak the mmp?

No. I think we need an upgrade routine. Also, I don't know if this has been, or should be, reported upstream.

@Rossmaxx
Copy link
Contributor

For me, the file opened fine without any errors.

@zonkmachine
Copy link
Contributor

zonkmachine commented Apr 13, 2024 •
edited
Loading

On a Swedish computer.

image

@Rossmaxx
Copy link
Contributor

So is this error language dependent?

@zonkmachine
Copy link
Contributor

zonkmachine commented Apr 13, 2024 •
edited
Loading

So is this error language dependent?

Locale dependent, yes. See this comment above: #5167 (comment)

@michaelgregorius
Copy link
Contributor

I have a pull request which fixes half of the problem, i.e. the locale dependent delay names in the delay plugins: LMMS/cmt#6.

Once this is merged the other half of the fix would be to write an upgrade routine in the LMMS loading code which replaces all delay names that contain commas with the ones that contain dots. Otherwise this might break the projects of people which use locales that have originally loaded the plugins with commas in their names and which have saved them as such.

@michaelgregorius
Copy link
Contributor

Pull request #7206 implements the upgrade routine. It must only be merged if the CMT pull request was merged!

@michaelgregorius michaelgregorius linked a pull request Apr 13, 2024 that will close this issue
Add upgrade for CMT delays #7206
Merged
michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Apr 14, 2024
@michaelgregorius
Bump CMT to d8bf8084aa3
0e3ee2f 
Bump the CMT submodule to commit d8bf8084aa3 which contains the fixes for issue LMMS#5167. The delays now always report the same name strings.
michaelgregorius added a commit that referenced this issue Apr 14, 2024
@michaelgregorius
Update CMT submodule / Upgrade code for CMT delays (#7206)
d2c2a80 
## Bump CMT to d8bf8084aa3
Bump the CMT submodule to commit d8bf8084aa3 which contains the underlying fixes for issue #5167.

The CMT delay uses `sprintf` calls to generate the technical names and display names of the delays. These calls are locale dependent. As a consequence for example the feedback delay might have been saved either as "fbdelay_0.1s" (point) or "fbdelay_0,1s" (comma) in a save file.

The CMT fix makes sure that all delays use points in their names and thus that they now always report the same name strings.

## Add upgrade routine for CMT delays
Add an upgrade routine for CMT delays which works in conjunction with the upgraded CMT submodule. Because the delays will now always report their name with points old save files which might contain versions with the comma must be upgraded to a name with a point.
@messmerd messmerd mentioned this issue Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upgrade for CMT delays michaelgregorius/lmms
6 participants
@zonkmachine @trebmuh @michaelgregorius @DanielChabrowski @PhysSong @Rossmaxx