Fix out-of-bounds access and remove MSVC function export #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresf
approved these changes
May 9, 2024
Veratil
approved these changes
May 9, 2024
There was a problem hiding this comment.
LGTM and tested MSVC build fixup with LMMS/lmms#6973 fix to CMakeLists.txt for cmt
JohannesLorenz
approved these changes
May 9, 2024
This reverts commit 835108b. This change is redundant and does not fix the bug it was intended to.
We now use a linker option to export the function, so that the code remains compatible with a vanilla ladspa.h when building with MSVC.
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #4, and reverts #5. We decided to specify the function export using a linker flag, rather than an attribute in the code, so that the code continues to work with a vanilla
ladspa.h. See #5 (comment) for details on the out-of-bounds fix.