Fixes to enable building on msvc

[Rossmaxx]

Added a M_PI macro to enable building on msvc. Very minor change, easy merge.

[tresf]

@Rossmaxx, thanks! I did some quick digging and found the following:

• Merge v1.18 from main #3
• cmt - Delay Line, wrong delay with setting 0 lmms#6006

Since #3 doesn't seem to contain this patch, it should be safe to merge, however, the patch needs to land upstream as well. The way we do this currently is to email the author of CMT. Here's the email address:

anti-spam measure - email address hidden -- click to expand

richard [at] muse.demon [dot] co.uk

These older methods of patching would use a .patch file, but it would be created against whatever latest version is available.

http://www.ladspa.org/download/index.html

To that point, since you're working directly with the lmms/cmt submodule, I would invite you to report test results against #3 so that we can get that merged in while we have eyes on it.

[Rossmaxx]

however, the patch needs to land upstream as well.

forwarded the patch. gmail claims the mail id doesn't exist

since you're working directly with the lmms/cmt submodule, I would invite you to report test results against #3 so that we can get that merged in while we have eyes on it.

noted. will test this week.

[tresf]

gmail claims the mail id doesn't exist

I'll send it to you on Discord.

Discard, I think my email on file was outdated, please try this:

anti-spam measure - email address hidden -- click to expand

richard (at) muse440 (dot) com

[Rossmaxx]

I've sent it to him. Let's wait now.

[Rossmaxx]

update : Richard got back to me and after a few back and forth mails, it seems he might merge this fix. I'll get back once he merges it.

[tresf]

@Rossmaxx do you mind chiming in over at LMMS/lmms#6151? I'd like to toggle MSVC back on for this and I assume you've already done it locally.

[Rossmaxx]

do you mind chiming in over at LMMS/lmms#6151?

I would like to but I won't be able to, mainly cause debugging #6758 has started to become a bit of a headache. Let me fix that first.

I'd like to toggle MSVC back on for this and I assume you've already done it locally.

Not yet. Calf plugins are failing. I'll fix that too then I'll look into it.

[tresf]

I'm sorry, I had forgotten that we have all LadspaEffect plugins blacklisted. No rush and thanks for the patch!

IF(MSVC)
	SET(MSVC_INCOMPATIBLE_PLUGINS
		LadspaEffect
		zynaddsubfx
	)
	message(WARNING "Compiling with MSVC. The following plugins are not available: ${MSVC_INCOMPATIBLE_PLUGINS}")
	LIST(REMOVE_ITEM PLUGIN_LIST ${MSVC_INCOMPATIBLE_PLUGINS})
ENDIF()