Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-bounds access and remove MSVC function export #7

Merged
merged 3 commits into from
May 10, 2024
Merged

Fix out-of-bounds access and remove MSVC function export #7

merged 3 commits into from
May 10, 2024

Commits on May 9, 2024

  1. Revert "prevent deletion of nullptr (LMMS#5)" 

    This reverts commit 835108b.

This change is redundant and does not fix the bug it was intended to.
    @DomClark
    DomClark committed May 9, 2024
    Configuration menu
    Copy the full SHA
    aea699e View commit details
    Browse the repository at this point in the history

  2. Fix delay line out-of-bounds port access

    @DomClark
    DomClark committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dde9938 View commit details
    Browse the repository at this point in the history

  3. Remove MSVC dllexport attribute 

    We now use a linker option to export the function, so that the code
remains compatible with a vanilla ladspa.h when building with MSVC.
    @DomClark
    DomClark committed May 9, 2024
    Configuration menu
    Copy the full SHA
    abc8106 View commit details
    Browse the repository at this point in the history