Update Gateway status on ReferenceGrant changes #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwrite test Gateways and GatewayClasses to ease cluster reuse.
rainest
force-pushed
the
fix/always-update-status
branch
from
d04ee36
to
b543eee
Compare
rainest
force-pushed
the
fix/always-update-status
branch
from
b543eee
to
bd7243b
Compare
rainest
force-pushed
the
fix/always-update-status
branch
from
bd7243b
to
396ed97
Compare
randmonkey
requested changes
Aug 10, 2022
mlavacca
requested changes
Aug 10, 2022
Exclude ReferenceGrants that do not handle Gateways. Require Gateway group.
rainest
force-pushed
the
fix/always-update-status
branch
from
d416ed9
to
33bcae2
Compare
rainest
force-pushed
the
fix/always-update-status
branch
from
33bcae2
to
5a5cabe
Compare
randmonkey
reviewed
Aug 11, 2022
pmalek
reviewed
Aug 11, 2022
randmonkey
approved these changes
Aug 11, 2022
|
@mlavacca can you approve as well? Apparently GH is stuck on the old review--not really sure, but I can't see any reason it's indicating your change request is still active. |
mlavacca
approved these changes
Aug 11, 2022
This was referenced Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reconciles a Gateway if the controller sees a ReferenceGrant that has a From clause for the Gateway.
Update Gateway statuses on every reconcile if they have changed, not just on creation.
Changes Gateway(Class) deploy test helpers to delete existing resources before creating new ones, to ease cluster re-use.
Which issue this PR fixes:
fix #2785
fix #2786
Special notes for your reviewer:
Contrary to #2785, this does not involve #2694, as the ReferenceGrant Condition is part of Listener status, not the Gateway status. Although Listener statuses are part of the Gateway status, they have their own Condition sets. I don't believe we needed anything to make Listener status conditions a snapshot other than updating them on each reconcile (not doing this earlier was a bug), since we generate them from scratch each time (we do use the previous conditions to make decisions about how to generate the new set, but we do not append them).
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PRJust lists the status fix; the rest is tests or part of the ReferenceGrant changes that are already staged for 2.6.