Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep listener status updated #2785

Closed
1 of 2 tasks
mlavacca opened this issue Aug 8, 2022 · 1 comment · Fixed by #2797
Closed
1 of 2 tasks

Keep listener status updated #2785

mlavacca opened this issue Aug 8, 2022 · 1 comment · Fixed by #2797
Assignees
Labels
area/feature New feature or request

Comments

@mlavacca
Copy link
Member

mlavacca commented Aug 8, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

As of now, the listener status is initialized only when the gateway is not ready yet; in this case, all the listeners are set with the proper status, and the gateway resource is updated. This approach that we currently have led to not reconciling the correct listener status whenever it changes and having an inappropriate gateway status under some circumstances, such as whenever a listener is not ready anymore because of a ReferenceGrant missing or malformed (introduced in #2774).

Proposed Solution

At every gateway reconciliation loop, we should compute the expected gateway status and compare it to the actual one; if they differ, the gateway resource should be updated, no matter if the gateway is ready.

Additional information

This issue should be solved after #2694, because treating the gateway status as a snapshot instead of a ledger, will help a lot to structure the code properly.

Acceptance Criteria

  • Every time some event that triggers gateway reconciliation happens, the expected gateway status should be enforced on the gateway resource.
@mflendrich
Copy link
Contributor

blocked by #2694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants