-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gateway) handle NodePort addresses #2827
Conversation
Ensure that the controller's desired addresses for Services with no external addresses (such as NodePorts) match the Gateway representation of no addresses. This ensures that the address update check does not attempt to proceed with an unnecessary update every reconcile, which would prevent the Gateway from becoming ready.
736e847
to
8654ab4
Compare
This is currently affected by the failure that #2824 will fix. Draft waiting for that; this needs to be rebased after that's merged.
|
HTTPRoutes don't strip paths by default. We wrote tests that need them stripped.
On second thought, looking at that failure, configuring the route to strip paths makes more sense than intentionally causing a 404 and scraping the server header, so I've added that change here. |
OK, I did not find that we have an annotation to do the strip path of |
What this PR does / why we need it:
Ensure that the controller's desired addresses for Services with no external addresses (such as NodePorts) match the Gateway representation of no addresses. This ensures that the address update check does not attempt to proceed with an unnecessary update every reconcile, which would prevent the Gateway from becoming ready.
Add an E2E test that confirms Gateways work with NodePorts.
Which issue this PR fixes:
Fix #2808
Fix #2823
Special notes for your reviewer:
E2E run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/2871403290
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:thethis was a bug introduced by unreleased code from Update Gateway status on ReferenceGrant changes #2797CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR