Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.26.2 #4322

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Cut release v0.26.2 #4322

merged 6 commits into from
Oct 26, 2024

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Oct 25, 2024

What's Changed

Full Changelog: v0.26.1...v0.26.2

Copy link

qa-wolf bot commented Oct 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 26, 2024 6:06am

@lf94
Copy link
Contributor Author

lf94 commented Oct 26, 2024

Windows: Partial clear

Manual Tasks

  • Mash keyboard in code editor
  • Electron tests: external links open an external browser #3373
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
  • running app.{app,exe} path/to/file opens the kcl file (all oses) On windows this fails for me but it may be a local issue. It says permission denied for APPDATA folder in devtools. But the app at least opens hella fast
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses) On windows this fails for me but it may be a local issue. It says permission denied for APPDATA folder in devtools. App opens hella fast tho
  • If someone at the office, test you can hit make from the app and it works
  • Test updating versions works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
  • Electron tests: ensure we can open files that in tauri we would not be able to #3455
  • Electron test: upgrading app should not cause user to have to auth again #3469
  • Electron: logging in and authing works #3465
  • double click to open files from finder opens new window each time (mac/windows) On windows this fails for me but it may be a local issue. It says permission denied for APPDATA folder in devtools.
  • export from the app works and opens a file picker ux (needs to be manual since we override for playwright)
  • Ensure that a loading toast appears when testing the auto-updater, saying the download has begun
  • Token.txt should work #4038

I've tried complete uninstall but the APPDATA perms error persists. I filed an issue

@lf94
Copy link
Contributor Author

lf94 commented Oct 26, 2024

Mac: Clear

Manual Tasks

@lf94 lf94 merged commit 239ab68 into main Oct 26, 2024
26 checks passed
@lf94 lf94 deleted the cut-release-v0.26.2 branch October 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants