Tags should refer to full paths, not just base paths. #4299
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/path-seg-type-in-tag
branch
2 times, most recently
from
314e50c to
560fdc9
Compare
adamchalmers
force-pushed
the
achalmers/path-seg-type-in-tag
branch
from
560fdc9 to
775b966
Compare
See "Problem 2" in #4297 This is a pure refactor, it should not change any behaviour at all. It adds more information into the tag system, but nothing reads that extra information yet. It will be used to address problem 3 of the above issue.
adamchalmers
force-pushed
the
achalmers/path-seg-type-in-tag
branch
from
775b966 to
d69fb2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
==========================================
- Coverage 85.82% 85.80% -0.03%
==========================================
Files 77 77
Lines 27167 27189 +22
==========================================
+ Hits 23317 23330 +13
- Misses 3850 3859 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| pub fn get_from(&self) -> &[f64; 2] { | ||
| &self.get_base().from | ||
| } | ||
| /// Where does this path segment end? | ||
| pub fn get_to(&self) -> &[f64; 2] { | ||
| &self.get_base().to | ||
| } |
There was a problem hiding this comment.
Why the unnecessary indirection?
There was a problem hiding this comment.
In the future we're not going to know the start/end of lines so easily (we'll need to query wasm or the API) so this change is preparation for that.
There was a problem hiding this comment.
get_base() though is already abstracting
will be done today |
See "Problem 2" in #4297
This is a pure refactor, it should not change any behaviour at all.
It adds more information into the tag system, but nothing reads that
extra information yet. It will be used to address problem 3 of the above
issue.