Chore: Don't let draft lines receive mouseEnter/Leave events, or create invalid overlays #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te invalid overlays
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
jtran
approved these changes
Oct 25, 2024
lf94
approved these changes
Oct 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the console gets spammed with errors when creating draft lines, making for noisy development. This was because draft segments were receiving the normal segment onMouseEnter and onMouseLeave listeners, and were being provided constraint overlays, even though they aren't yet in the AST. This marks those segments as draft so they can be excluded from receiving the listeners or the overlay components.
No new tests because this removes console.log only behavior. All the existing tests passing should verify no behavior has changed.
Demo
Screenshare.-.2024-10-25.11_49_26.AM-compressed.mp4