Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some llvm FP intrinsic in llvm-spirv #855

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Dec 10, 2020

Signed-off-by: gejin ge.jin@intel.com

Signed-off-by: gejin <ge.jin@intel.com>
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Dec 11, 2020

Hi, @bader and @AlexeySotkin
Who should I turn to for a code review in SPIRV-LLVM-Translator repo?
Thanks very much.

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this LGTM

@@ -0,0 +1,346 @@
; RUN: llvm-as %s -o %t.bc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this file into test/llvm-intrinsics directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: gejin <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Dec 17, 2020

It seems that latest llvm-spirv build failed....

@Fznamznon
Copy link
Contributor

It seems that latest llvm-spirv build failed....

Build should be fixed by #856 . Please try to do merge with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants