-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for some llvm FP intrinsic in llvm-spirv #855
Add support for some llvm FP intrinsic in llvm-spirv #855
Conversation
Signed-off-by: gejin <ge.jin@intel.com>
Signed-off-by: gejin <ge.jin@intel.com>
Hi, @bader and @AlexeySotkin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this LGTM
test/fp-intrinsics.ll
Outdated
@@ -0,0 +1,346 @@ | |||
; RUN: llvm-as %s -o %t.bc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move this file into test/llvm-intrinsics
directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: gejin <ge.jin@intel.com>
It seems that latest llvm-spirv build failed.... |
Build should be fixed by #856 . Please try to do merge with master. |
Signed-off-by: gejin ge.jin@intel.com