-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Enable some math builtins in SemaSYCL #3060
Conversation
Signed-off-by: gejin <ge.jin@intel.com>
/summary:run |
Signed-off-by: gejin <ge.jin@intel.com>
Signed-off-by: gejin <ge.jin@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would change the title of the PR.
"[SYCL] Enable some math builtins in SemaSYCL" - most of the enabled built-ins are not from "math" category.
@Ralender would this solve some crashes we have on math stuff? |
Hi, @keryell |
I was not thinking to Intel related crashes but to Xilinx related crashes. |
Signed-off-by: gejin ge.jin@intel.com
This PR aims to enable some math builtin in SemaSYCL. We supported some llvm math intrinsic in this PR:
KhronosGroup/SPIRV-LLVM-Translator#855
So a bunch of math builtin which depend on those llvm math intrinsic can work now. This PR enables following math builtin:
fmax/f (depends on llvm.maxnum)
fmin/f (depends on llvm.minnum)
isinf (depends on llvm.fabs)
isfinite (depends on llvm.fabs)
isnormal (depends on llvm.fabs)
fpclassify (depends on llvm.fabs)