Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][DOC] DeviceLib doc update to add new supported items #3623

Merged
merged 2 commits into from
May 7, 2021

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 27, 2021

Signed-off-by: gejin ge.jin@intel.com

@jinge90 jinge90 requested a review from a team as a code owner April 27, 2021 05:35
Signed-off-by: gejin <ge.jin@intel.com>
Signed-off-by: gejin <ge.jin@intel.com>
@jinge90 jinge90 requested review from vzakhari and bader April 30, 2021 02:28
@bader
Copy link
Contributor

bader commented Apr 30, 2021

@jinge90, could you remind me PR/commit IDs where these functions were added, please?

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 30, 2021

@jinge90, could you remind me PR/commit IDs where these functions were added, please?

Hi, @bader
#3262 is for adding support div, ldiv, lldiv.
#3364 is for adding support abs, labs,llabs

And a bunch of math functions are removed from list of math function unsupported although we didn't add any support in SYCL device library. The reason is those math functions are converted to corresponding llvm intrinsic and llvm-spirv has supported those intrinsic, so they can work in SYCL device now, The corresponding PR is: KhronosGroup/SPIRV-LLVM-Translator#855
Thanks very much.

@bader
Copy link
Contributor

bader commented Apr 30, 2021

Thanks, but I can't find scalbn and nextafter implementations in provided PRs.

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 30, 2021

Thanks, but I can't find scalbn and nextafter implementations in provided PRs.

Hi, @bader
For scalbn, we added long time ago but didn't update the doc
#2558

For nextafter, I think it was a mistake in initial version of the doc, this API was added long time ago in the first patch for cmath, complex device library, #975
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented May 6, 2021

Hi, @intel/dpcpp-specification-reviewers
Could you help review this change?
Thanks very much.

@jinge90 jinge90 requested a review from pvchupin May 7, 2021 01:11
@jinge90
Copy link
Contributor Author

jinge90 commented May 7, 2021

Add @pvchupin
Thanks very much.

@pvchupin pvchupin merged commit febfb5a into intel:sycl May 7, 2021
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants