Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course automation: Automatic validation and labeling #949

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Course automation: Automatic validation and labeling #949

merged 2 commits into from
Mar 26, 2021

Conversation

altaired
Copy link

@altaired altaired commented Mar 23, 2021

Course automation: Automatic validation and labeling

Members

Simon Persson (siper@kth.se)

GitHub: @altaired

Proposal

I plan to make a github action that automatially asigns labels depending on the category of the proposal and a "proposal" label (if it is a new proposal). The action should also validate the folder naming structure and that a README file is included properly. This would allow the TA's to easily filter out what PR:s to check.

In order to achive this, the following will have to be done:

  • Validate the folder structure and README on each push
  • Check on each PR what file / files has been modified, to determine what category the PR is related to. Also check if files that should't have been modified are included and if that's the case, return an error to the user.
  • Assign the appropriate labels
  • Report back the status if the PR is following the required structure.
  • Create a report showing statistics over the number of proposals.

@SophieHYe
Copy link

Hi Simon,

Thanks for the interesting proposal.
"Check on each PR what file / files has been modified", maybe also think about the actions for some corner cases: multiple files/folders are modified, etc.
We would love to have a report from your work to trace the number/status/kth_ids/other details of all PRs.

Please update your PR accordingly, then we will merge it soon. Thanks!

@altaired
Copy link
Author

altaired commented Mar 25, 2021

If I understand the process of a proposal correctly it is supposed to initially ONLY contain a README.md file, or are other files for a proposal allowed? The action would make sure only one user-user/category folder is modified per PR (if multiple it is not approved?). In terms of statistics, would it be interesting to see how many of each category is submitted, the total number of proposals a.s.o, or which statistics are interesting for you to have? I'm thinking as there was a PR merged already for summarizing statistics in a file.

I've changed the proposal a little bit, is that what you mean @SophieHYe ?

@SophieHYe
Copy link

Hi,

  • If I understand the process of a proposal correctly it is supposed to initially ONLY contain a README.md file, or are other files for a proposal allowed?

In theory, Yes. You understood correctly. But we always do have some students modify multiple files to register multiple tasks. You can considered it as exceptions.

  • In terms of statistics, would it be interesting to see how many of each category is submitted, the total number of proposals a.s.o, or which statistics are interesting for you to have? I'm thinking as there was a PR merged already for summarizing statistics in a file.

Yes, indeed other students would like to contribute in the statistics. It would be nice if you can operator.

Thanks for the update. I am now merging your PR.

@SophieHYe SophieHYe merged commit db7a3fc into KTH:2021 Mar 26, 2021
arxra added a commit to arxra/devops-course that referenced this pull request Mar 29, 2021
* '2021' of github.com:KTH/devops-course: (52 commits)
  doc: Course automation proposal (KTH#1008)
  Adds essay proposal (KTH#1009)
  Create readme.md (KTH#996)
  Create README.md (KTH#995)
  doc: add essay proposal for devops course (KTH#988)
  Presentation Proposal: Continuous testing and its role & application within devops (KTH#1026)
  Executable tutorial: nginx on vagrant box (KTH#956)
  Presentation week2 (KTH#1005)
  Course automation: Verify pull request content changes (KTH#981)
  Presentation: The history of devops (KTH#1004)
  Presentation : Influence of DevOps in Software testing (KTH#984)
  Course automation: Automatic validation and labeling (KTH#949)
  Essay: Automated tests for infrastructure code (KTH#999)
  Demo: How to add code coverage report on Github using Clover and GitHub Action (KTH#994)
  Demo proposal: Implementation of Docker to React Application (KTH#992)
  Course Automation: automatic labels (KTH#932)
  Update README.md
  Reschedule Nix presentation to week 2 (KTH#1001)
  Course Automation: Upvote other students' work (KTH#991)
  Presentation Kanban vs Scrum (KTH#993)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants