Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course automation: Automatic duplicate proposal detection #959

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Course automation: Automatic duplicate proposal detection #959

merged 4 commits into from
Mar 24, 2021

Conversation

johennin
Copy link

Automatic duplicate proposal detection

Members

Lee Badal (badal@kth.se)

GitHub: @LeeBadal

Johan Henning (johennin@kth.se)

GitHub @johennin

Proposal

We plan to create a github action that validates that no previous/similar proposals have been made before.

To verify that the PR is a proposal we intend to test the folder structure or validate that a proposal label is assigned (if #949 is implemented)
We will then run a semantic analysis comparator to previous PR(Title and description) proposals and notify the user/TA's by writing a comment if they are above a certain threshold of similarity or if manual revision by a TA is required. (In this case the URLs to the similar PR will be provided)

Proposed tools

  • Github Actions
  • NLTK

Copy link

@cesarsotovalero cesarsotovalero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeeBadal: is this your KTH account? If not, please change.

@LeeBadal
Copy link

@cesarsotovalero if you are wondering if this account is linked to my kth mail address, then yes.

@cesarsotovalero
Copy link

@cesarsotovalero if you are wondering if this account is linked to my kth mail address, then yes.

No, I mean that you should use badal instead.

@LeeBadal
Copy link

@cesarsotovalero if you are wondering if this account is linked to my kth mail address, then yes.

No, I mean that you should use badal instead.

Sorry I'm not quite following, that is not possible because that username is already taken. Please clarify why/where this account is an issue and perhaps I will understand what you want me to change.

@cesarsotovalero
Copy link

cesarsotovalero commented Mar 24, 2021

Group Rules

  • When you send a pull request for registration, please follow the name convention of using email addresses of two members to create the folder: email-email.

Your email is badal@kth.se, so the name of the folder in your pull request should be contributions/course-automation/badal-johennin/README.md

Is this clear to you now?

… contributions/course-automation/badal-johennin/README.md
@johennin
Copy link
Author

johennin commented Mar 24, 2021

Hi, changes made, sorry about that!
@cesarsotovalero

@cesarsotovalero
Copy link

LGTM now, I'll merge.

@cesarsotovalero cesarsotovalero merged commit b42a0b4 into KTH:2021 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants