Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course automation: Verify pull request content changes #981

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

bubriks
Copy link

@bubriks bubriks commented Mar 24, 2021

Course automation: Verify pull request content changes

Members

Ralfs Zangis (zangis@kth.se)
GitHub: Ralfs

Proposal

Ensuring that pull requests can be approved only if the formatting requirements are met.

Description

  • Check changed .md file contents (contains: task name, members, and description)
  • Verify that the member names (from README.md) are represented in the containing folder name
  • Confirm that file structure follows the rules (no changes outside members folder in the selected category)
  • Disallow pull request approval if any checks have failed

@khaes-kth
Copy link

In you description, I think you can be more specific in your third point. Each PR should only register one topic, so we cannot have changes in all 7 category folders. Right?

@bubriks
Copy link
Author

bubriks commented Mar 25, 2021

I agree and it should be fixed now :)

@khaes-kth khaes-kth merged commit 77b4444 into KTH:2021 Mar 26, 2021
arxra added a commit to arxra/devops-course that referenced this pull request Mar 29, 2021
* '2021' of github.com:KTH/devops-course: (52 commits)
  doc: Course automation proposal (KTH#1008)
  Adds essay proposal (KTH#1009)
  Create readme.md (KTH#996)
  Create README.md (KTH#995)
  doc: add essay proposal for devops course (KTH#988)
  Presentation Proposal: Continuous testing and its role & application within devops (KTH#1026)
  Executable tutorial: nginx on vagrant box (KTH#956)
  Presentation week2 (KTH#1005)
  Course automation: Verify pull request content changes (KTH#981)
  Presentation: The history of devops (KTH#1004)
  Presentation : Influence of DevOps in Software testing (KTH#984)
  Course automation: Automatic validation and labeling (KTH#949)
  Essay: Automated tests for infrastructure code (KTH#999)
  Demo: How to add code coverage report on Github using Clover and GitHub Action (KTH#994)
  Demo proposal: Implementation of Docker to React Application (KTH#992)
  Course Automation: automatic labels (KTH#932)
  Update README.md
  Reschedule Nix presentation to week 2 (KTH#1001)
  Course Automation: Upvote other students' work (KTH#991)
  Presentation Kanban vs Scrum (KTH#993)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants