Course automation proposal: Verify PR submitted have Github ids and KTH ids match students registered to the course

[KallePettersson]

Course automation proposal: Verify PR submitted have Github id's and KTH ids matching students registered to the course

Members

Kalle Pettersson (kalpet@kth.se)
GitHub: KallePettersson

Anders Nillson (andnil5@kth.se)
GitHub: andnil5

Proposal

We want to solve the issue described by baudry in #916.
"Check that all PR submitted for the course come from a Github id that corresponds to one KTH id of a student who registered for the course"

Proposed solution:

• Create a GitHub javascript action to be run on each PR.
• Extract the GitHub id of the PR author.
• Create a list of valid kth ids (from students registered to course).
• If GitHub id matches kth id, approve PR.
• Otherwise, check that the Member mail address in the README match.
• Utilize Status checks API to visualize the result.

[SophieHYe]

Hi,

Thanks for your proposal. Indeed this is a very useful step for course automation.

Could you please also update your preliminary solution in this PR?
We want to make sure if your solution is original enough and difficult enough, and if your solution is feasible for the future students who would take the DevOps course in the coming years. Thanks.

[andnil5]

Thanks for your feedback, @SophieHYe. If we understood it correctly, the proposal should now cover a description of the preliminary solution.

[SophieHYe]

Hi,
Thanks for the update. Just a little bit of concerns about "If GitHub id matches kth id, approve PR."

A bit of context for you, in this course, we are not ready for the automatic PR approval as the TAs need to review all PRs.
Because once a PR is merged, it means: we are 100% sure that the topic is

1. related to DevOps
2. original enough
3. difficult enough (but not infeasible)

Rather than approve PR, maybe you can somehow notify TAs that this GitHub id matches kth id.
The other plan looks excellent. I am now merging it.