Skip to content

Commit

Permalink
Course automation proposal: Verify PR submitted have Github ids and K…
Browse files Browse the repository at this point in the history
…TH ids match students registered to the course (#929)

* Draft README for course-automation task

* Updated the proposal

Co-authored-by: Kalle Pettersson <kalpet@kth.se>
  • Loading branch information
KallePettersson and Kalle Pettersson authored Mar 25, 2021
1 parent e445cd0 commit 259b379
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions contributions/course-automation/kalpet-andnil5/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Course automation proposal: Verify PR submitted have Github id's and KTH ids matching students registered to the course

## Members

Kalle Pettersson (kalpet@kth.se)
GitHub: [KallePettersson](https://github.com/KallePettersson)

Anders Nillson (andnil5@kth.se)
GitHub: [andnil5](https://github.com/andnil5)

## Proposal
We want to solve the issue described by baudry in #916.
"Check that all PR submitted for the course come from a Github id that corresponds to one KTH id of a student who registered for the course"

## Proposed solution:

* Create a GitHub javascript action to be run on each PR.
* Extract the GitHub id of the PR author.
* Create a list of valid kth ids (from students registered to course).
* If GitHub id matches kth id, approve PR.
* Otherwise, check that the Member mail address in the README match.
* Utilize Status checks API to visualize the result.

0 comments on commit 259b379

Please sign in to comment.