Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course automation proposal: Verify PR submitted have Github ids and KTH ids match students registered to the course #929

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Course automation proposal: Verify PR submitted have Github ids and KTH ids match students registered to the course #929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e914c9
Draft README for course-automation task
Mar 23, 2021
6c159bb
Updated the proposal
Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions contributions/course-automation/kalpet-andnil5/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Course automation proposal: Verify PR submitted have Github id's and KTH ids matching students registered to the course

## Members

Kalle Pettersson (kalpet@kth.se)
GitHub: [KallePettersson](https://github.com/KallePettersson)

Anders Nillson (andnil5@kth.se)
GitHub: [andnil5](https://github.com/andnil5)

## Proposal
We want to solve the issue described by baudry in #916.
"Check that all PR submitted for the course come from a Github id that corresponds to one KTH id of a student who registered for the course"

## Proposed solution:

* Create a GitHub javascript action to be run on each PR.
* Extract the GitHub id of the PR author.
* Create a list of valid kth ids (from students registered to course).
* If GitHub id matches kth id, approve PR.
* Otherwise, check that the Member mail address in the README match.
* Utilize Status checks API to visualize the result.