Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pull image via ecr pull cache #921

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: pull image via ecr pull cache #921

merged 1 commit into from
Dec 5, 2024

Conversation

ggera
Copy link
Member

@ggera ggera commented Dec 5, 2024 •
edited
Loading

fixes KILTProtocol/ticket#3600

standalone-node is pushed only to docker-hub & to avoid rate limit I introduced ecr-pull-cache

How to test:

docker pull $AWS_ACCOUNT.dkr.ecr.$REGION.amazonaws.com/dh/kiltprotocol/standalone-node

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@ggera ggera requested review from ntn-x2 and rflechtner December 5, 2024 15:15
rflechtner
rflechtner approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I remember @ntn-x2 saying that some issue with the polkadot sdk removed all our runtime calls on develop, so these tests failing now makes a lot of sense.

@rflechtner rflechtner merged commit a5e05f3 into develop Dec 5, 2024
13 of 15 checks passed
@rflechtner rflechtner deleted the ecr-pull-cache branch December 5, 2024 17:30
@ntn-x2
Copy link
Member

ntn-x2 commented Dec 6, 2024

@rflechtner the PR was merged last week, so it should not an issue anymore: KILTprotocol/kilt-node#809

rflechtner pushed a commit that referenced this pull request Jan 16, 2025
@ggera @rflechtner
chore: pull image via ecr pull cache (#921)
72cdeae 
Contributed by @ggera
@rflechtner rflechtner mentioned this pull request Jan 16, 2025
Merged
5 tasks
rflechtner added a commit that referenced this pull request Jan 16, 2025
@rflechtner
test: fix tests & ci (#932)
fd3c7df 
* chore: replace all uses of tx.balances.transfer() (#903)
* ci: run tests on prs to v0-lts
* ci: update actions (backport of #871)
* fix: update playwright dep
* fix: rename Docker image (#902)
* chore: pull image via ecr pull cache (#921)
---------
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
Co-authored-by: Antonio <antonio@kilt.io>
Co-authored-by: Gerawork Aynekulu <ggera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

@ntn-x2 ntn-x2 Awaiting requested review from ntn-x2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggera @ntn-x2 @rflechtner