Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace all uses of tx.balances.transfer() #903

Merged
merged 3 commits into from
Sep 5, 2024
Merged

chore: replace all uses of tx.balances.transfer() #903

merged 3 commits into from
Sep 5, 2024

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Sep 4, 2024 •
edited
Loading

re/ KILTProtocol/ticket#3582

Replaces all uses of the deprecated balances.transfer extrinsic.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner marked this pull request as ready for review September 5, 2024 14:39
Dudleyneedham
Dudleyneedham approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rflechtner rflechtner merged commit 4781dc8 into develop Sep 5, 2024
11 of 15 checks passed
@rflechtner rflechtner deleted the rf-replace-transfer branch September 5, 2024 15:44
rflechtner added a commit that referenced this pull request Jan 16, 2025
@rflechtner
chore: replace all uses of tx.balances.transfer() (#903)
6d769d7 
* chore: replace all uses of tx.balances.transfer()
* test: update mocks
@rflechtner rflechtner mentioned this pull request Jan 16, 2025
Merged
5 tasks
rflechtner added a commit that referenced this pull request Jan 16, 2025
@rflechtner
test: fix tests & ci (#932)
fd3c7df 
* chore: replace all uses of tx.balances.transfer() (#903)
* ci: run tests on prs to v0-lts
* ci: update actions (backport of #871)
* fix: update playwright dep
* fix: rename Docker image (#902)
* chore: pull image via ecr pull cache (#921)
---------
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
Co-authored-by: Antonio <antonio@kilt.io>
Co-authored-by: Gerawork Aynekulu <ggera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dudleyneedham Dudleyneedham Dudleyneedham approved these changes

@ntn-x2 ntn-x2 Awaiting requested review from ntn-x2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @Dudleyneedham