chore: update to node v20

[rompemoldes]

fixes part of KILTProtocol/ticket#3081

• Makes sure the package.json specifies yarn version.
• Upgrades the used node version on the .nvmrc to lts/Iron.
• Makes sure the GitHub workflows uses node version 20.
  For this following must be set:
  • actions/checkout@v4
  • actions/setup-node@v4 with: either
    • node-version-file: 'package.json' or '.nvmrc'
    • node-version: '<Node.js version using SemVer or aliases > '
    • actions/download-artifact@v4
    • optional, but done: actions/cache@v4
  • aws-actions/configure-aws-credentials@v4
  • aws-actions/amazon-ecr-login@v2
• Makes sure the Dockerfiles also use the node version 20.
  This means that the following must be set:
  • FROM node:20-alpine as builder
• It also updates dependencies: mostly to latest minor, but major for ones with complains. Dropped.

[rompemoldes]

run integration tests (esm) is failing ;(

[rflechtner]

22 is not yet an active LTS, I'd say we make it optional for now. For this, add it to the 'include' instead

[rompemoldes]

Did it here 0404a5e.

Fix it here: c19d08a.

[rompemoldes]

Node v22 will be lts in about 3 months. The docker image running the thing `From:node-alpine` actually has node v22 preinstalled. Andrés RodríguezOn 13. Jun 2024, at 10:35, Raphael Flechtner ***@***.***> wrote: @rflechtner commented on this pull request. In .github/workflows/tests-polkadot-deps.yml:

@@ -58,7 +58,7 @@ jobs:

strategy: matrix: - node-version: [18.x, 20.x] + node-version: [18.x, 20.x, 22.x] 22 is not yet an active LTS, I'd say we make it optional for now. For this, add it to the 'include' In .github/workflows/tests.yml:

@@ -80,7 +80,7 @@ jobs:

strategy: matrix: - node-version: [18, 20] + node-version: [18, 20, 22] same here —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[rompemoldes]

For some reason. If the node v22 is optional, an integration test fails. If it required, it passes.

[ntn-x2]

@kilted-andres as far as I could see, the error you were getting is unrelated to making Node 22 optional or not. It seems to be some sort of concurrency issue in the tests. I would suggest the following: update the PR to make Node 22 optional. If the integration tests fail, re-run only those again from the GitHub UI, then it should be good to go.

[rompemoldes]

@ntn-x2 :

@kilted-andres as far as I could see, the error you were getting is unrelated to making Node 22 optional or not. It seems to be some sort of concurrency issue in the tests. I would suggest the following: update the PR to make Node 22 optional. If the integration tests fail, re-run only those again from the GitHub UI, then it should be good to go.

I tried that before "reverting" it.

[rflechtner]

LGTM now